Change in ...coreboot[master]: mb/purism: Select NO_POST instead of overriding its dependencies
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30925
Change subject: mb/purism: Select NO_POST instead of overriding its dependencies ......................................................................
mb/purism: Select NO_POST instead of overriding its dependencies
Declaring a Kconfig symbol ahead to override its default also always sets implicit dependencies. If the original symbol doesn't have any, Kconfig gets confused.
Change-Id: Ie6d9ca96e4b6037eefd432dd386cb5e540deb0ed Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/purism/librem_bdw/Kconfig M src/mainboard/purism/librem_skl/Kconfig 2 files changed, 2 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/30925/1
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index f9016b9..7f7519c 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -7,6 +7,7 @@ select HAVE_ACPI_TABLES select INTEL_INT15 select SOC_INTEL_BROADWELL + select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_BDW
@@ -63,12 +64,6 @@ int default 8
-config NO_POST - def_bool y - help - This platform does not have any way to see POST codes - so disable them by default. - config PRE_GRAPHICS_DELAY int default 50 diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index 12d4bcb..224779d 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -11,6 +11,7 @@ select MAINBOARD_USES_FSP2_0 select SPD_READ_BY_WORD select MAINBOARD_HAS_LPC_TPM + select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_SKL
@@ -54,12 +55,6 @@ int default 8
-config NO_POST - def_bool y - help - This platform does not have any way to see POST codes - so disable them by default. - config VGA_BIOS_ID string default "8086,1916"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30925 )
Change subject: mb/purism: Select NO_POST instead of overriding its dependencies ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30925 )
Change subject: mb/purism: Select NO_POST instead of overriding its dependencies ......................................................................
mb/purism: Select NO_POST instead of overriding its dependencies
Declaring a Kconfig symbol ahead to override its default also always sets implicit dependencies. If the original symbol doesn't have any, Kconfig gets confused.
Change-Id: Ie6d9ca96e4b6037eefd432dd386cb5e540deb0ed Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/30925 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_bdw/Kconfig M src/mainboard/purism/librem_skl/Kconfig 2 files changed, 2 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index f9016b9..7f7519c 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -7,6 +7,7 @@ select HAVE_ACPI_TABLES select INTEL_INT15 select SOC_INTEL_BROADWELL + select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_BDW
@@ -63,12 +64,6 @@ int default 8
-config NO_POST - def_bool y - help - This platform does not have any way to see POST codes - so disable them by default. - config PRE_GRAPHICS_DELAY int default 50 diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index 12d4bcb..224779d 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -11,6 +11,7 @@ select MAINBOARD_USES_FSP2_0 select SPD_READ_BY_WORD select MAINBOARD_HAS_LPC_TPM + select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_SKL
@@ -54,12 +55,6 @@ int default 8
-config NO_POST - def_bool y - help - This platform does not have any way to see POST codes - so disable them by default. - config VGA_BIOS_ID string default "8086,1916"
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)