Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Makefile: Allow to source code from mainboard/intel/common
Change-Id: Idb104a1baeacc742abe9e4f46e39d41f2da96c5a Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/37706/1
diff --git a/Makefile.inc b/Makefile.inc index dc5272e..d9869e5 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -97,6 +97,7 @@ subdirs-y += util/futility util/marvell util/bincfg subdirs-y += $(wildcard src/arch/*) subdirs-y += src/mainboard/$(MAINBOARDDIR) +subdirs-$(CONFIG_MAINBOARD_INTEL_COMMON) += src/mainboard/intel/common subdirs-y += src/security subdirs-y += payloads payloads/external
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37706/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37706/3//COMMIT_MSG@7 PS3, Line 7: Makefile: Allow to source code from mainboard/intel/common Suggestion: Add mainboard/intel/common
Add some info around reason to add this patch set.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37706/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37706/3//COMMIT_MSG@7 PS3, Line 7: Makefile: Allow to source code from mainboard/intel/common
Suggestion: Add mainboard/intel/common […]
Sure, Will add the details.
Hello Subrata Banik, Lean Sheng Tan, Maulik V Vaghela, Rizwan Qureshi, V Sowmya, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37706
to look at the new patch set (#4).
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Makefile: Allow to source code from mainboard/intel/common
Current build rules allows to build only the mainboard directory as per the mainboard selected. CB:37705 added support to common intel mainboard with intent to host the common APIs shared across Intel mainboards. This common API pool needs to be made available to intel mainboards which selects MAINBOARD_INTEL_COMMON config.
Change-Id: Idb104a1baeacc742abe9e4f46e39d41f2da96c5a Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/37706/4
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37706/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37706/3//COMMIT_MSG@7 PS3, Line 7: Makefile: Allow to source code from mainboard/intel/common
Sure, Will add the details.
Done
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37706/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37706/4//COMMIT_MSG@7 PS4, Line 7: Makefile: Allow to source code from mainboard/intel/common 'Add mb/intel/common'
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Patch Set 4: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37706/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37706/4/Makefile.inc@100 PS4, Line 100: subdirs-$(CONFIG_MAINBOARD_INTEL_COMMON) += src/mainboard/intel/common This does not belong here. It should be part of individual mainboards that use common definitions just like how cpu/intel/common subdir is included in individual SoCs
eg. subdirs-y += ../../../cpu/intel/common
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37706/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37706/4/Makefile.inc@100 PS4, Line 100: subdirs-$(CONFIG_MAINBOARD_INTEL_COMMON) += src/mainboard/intel/common
This does not belong here. […]
Ok, Agree.
Aamir Bohra has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37706 )
Change subject: Makefile: Allow to source code from mainboard/intel/common ......................................................................
Abandoned
will include the build deps in mainboards
-
Aamir Bohra (Code Review) -
Frans Hendriks (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)