Attention is currently required from: Paul Menzel, Patrick Rudolph. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55127 )
Change subject: soc/intel/common/acpi: add ACPI S0ix _DSM for Intel Power Engine Plug-in ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55127/comment/c49a0647_613971c1 PS4, Line 9: ( UUID:
Please remove the space after (.
Done
https://review.coreboot.org/c/coreboot/+/55127/comment/c4857cf2_1467daf3 PS4, Line 22: need to implemented
needs to be implemented
Done
File src/soc/intel/common/block/acpi/acpi/pep.asl:
https://review.coreboot.org/c/coreboot/+/55127/comment/82a61d0b_42363f6e PS4, Line 16: #define PEPD_PMC_PWRM_LPM_REQ_BITS_DATA_LEN 1536
I’d only use the first macro, and calculate the bit value from it.
Done