Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32347
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
mb/google/sarien: Update GPIO GPP_C23 setting
GPIO pin GPP_C23 is used as level trigger but not edge trigger, also it not invented, correct it here.
BUG=b:128554235 TEST=Boot up arcada platform with stylus keep on touching the screen, the touch screen is still functional once in OS stage.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I2bee664198057e3997dda181a16b9a0388067036 --- M src/mainboard/google/sarien/variants/arcada/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32347/1
diff --git a/src/mainboard/google/sarien/variants/arcada/gpio.c b/src/mainboard/google/sarien/variants/arcada/gpio.c index 570ab4a..b66e1dd 100644 --- a/src/mainboard/google/sarien/variants/arcada/gpio.c +++ b/src/mainboard/google/sarien/variants/arcada/gpio.c @@ -104,7 +104,7 @@ /* UART2_TXD */ PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), /* SERVORX_UART */ /* UART2_RTS# */ PAD_NC(GPP_C22, NONE), /* UART2_CTS# */ PAD_CFG_GPI_APIC(GPP_C23, NONE, PLTRST, - EDGE_SINGLE, INVERT), /* TS_INT# */ + LEVEL, NONE), /* TS_INT# */
/* SPI1_CS# */ PAD_CFG_GPI_APIC(GPP_D0, NONE, PLTRST, EDGE_SINGLE, INVERT), /* MEDIACARD_IRQ# */
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32347 )
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32347/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32347/1//COMMIT_MSG@10 PS1, Line 10: invented inverted
Hello Casper Chang, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Mike Hsieh, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32347
to look at the new patch set (#2).
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
mb/google/sarien: Update GPIO GPP_C23 setting
GPIO pin GPP_C23 is used as level trigger but not edge trigger, also it not inverted, correct it here.
BUG=b:128554235 TEST=Boot up arcada platform with stylus keep on touching the screen, the touch screen is still functional once in OS stage.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I2bee664198057e3997dda181a16b9a0388067036 --- M src/mainboard/google/sarien/variants/arcada/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32347/2
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32347 )
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32347/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32347/1//COMMIT_MSG@10 PS1, Line 10: invented
inverted
Done
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32347 )
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32347 )
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32347/2/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/gpio.c:
https://review.coreboot.org/#/c/32347/2/src/mainboard/google/sarien/variants... PS2, Line 110: EDGE_SINGLE Ideally, we would want to apply level filter at the pad and the interrupt trigger at the APIC.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32347 )
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32347/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32347/2//COMMIT_MSG@9 PS2, Line 9: it : not inverted it is not inverted
https://review.coreboot.org/#/c/32347/2//COMMIT_MSG@11 PS2, Line 11: Everything according to the schematics?
https://review.coreboot.org/#/c/32347/2//COMMIT_MSG@13 PS2, Line 13: TEST=Boot up arcada platform with stylus keep on touching the screen, : the touch screen is still functional once in OS stage. So what problem was fixed in the first place?
Hello Casper Chang, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Mike Hsieh, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32347
to look at the new patch set (#3).
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
mb/google/sarien: Update GPIO GPP_C23 setting
GPIO pin GPP_C23 is used as level trigger but not edge trigger, also it is not inverted, correct it here. According to board schematic, GPP_C23 connected with 3.3v pull up, so the pin is low active.
BUG=b:128554235 TEST=Boot up arcada platform with stylus keep on touching the screen, the touch screen is still functional once in OS stage. Without change, touch screen is not functional at same scenario.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I2bee664198057e3997dda181a16b9a0388067036 --- M src/mainboard/google/sarien/variants/arcada/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32347/3
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32347 )
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32347/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32347/2//COMMIT_MSG@9 PS2, Line 9: it : not inverted
it is not inverted
Done
https://review.coreboot.org/#/c/32347/2//COMMIT_MSG@11 PS2, Line 11:
Everything according to the schematics?
Done
https://review.coreboot.org/#/c/32347/2//COMMIT_MSG@13 PS2, Line 13: TEST=Boot up arcada platform with stylus keep on touching the screen, : the touch screen is still functional once in OS stage.
So what problem was fixed in the first place?
Done
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32347 )
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
Patch Set 3: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32347 )
Change subject: mb/google/sarien: Update GPIO GPP_C23 setting ......................................................................
mb/google/sarien: Update GPIO GPP_C23 setting
GPIO pin GPP_C23 is used as level trigger but not edge trigger, also it is not inverted, correct it here. According to board schematic, GPP_C23 connected with 3.3v pull up, so the pin is low active.
BUG=b:128554235 TEST=Boot up arcada platform with stylus keep on touching the screen, the touch screen is still functional once in OS stage. Without change, touch screen is not functional at same scenario.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I2bee664198057e3997dda181a16b9a0388067036 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32347 Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Bora Guvendik bora.guvendik@intel.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/variants/arcada/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Bora Guvendik: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/variants/arcada/gpio.c b/src/mainboard/google/sarien/variants/arcada/gpio.c index 570ab4a..b66e1dd 100644 --- a/src/mainboard/google/sarien/variants/arcada/gpio.c +++ b/src/mainboard/google/sarien/variants/arcada/gpio.c @@ -104,7 +104,7 @@ /* UART2_TXD */ PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), /* SERVORX_UART */ /* UART2_RTS# */ PAD_NC(GPP_C22, NONE), /* UART2_CTS# */ PAD_CFG_GPI_APIC(GPP_C23, NONE, PLTRST, - EDGE_SINGLE, INVERT), /* TS_INT# */ + LEVEL, NONE), /* TS_INT# */
/* SPI1_CS# */ PAD_CFG_GPI_APIC(GPP_D0, NONE, PLTRST, EDGE_SINGLE, INVERT), /* MEDIACARD_IRQ# */
-
Bora Guvendik (Code Review) -
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)
-
Lijian Zhao (Code Review)
-
Paul Menzel (Code Review)