Attention is currently required from: Raul Rangel, Eric Lai, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74102 )
Change subject: mb/google/myst: Add FW_CONFIG
......................................................................
Patch Set 21:
(1 comment)
File src/mainboard/google/myst/variants/myst/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74102/comment/6951e913_681c52f9
PS4, Line 20:
e.g. https://review.coreboot. […]
EMMC's are on a bayhub nvme bridge, and for the most part to us they're just slightly different nvme. We don't need a specific fw_config for it. This is how we worked it on Skyrim as well. OEM's may choose to handle it differently, but our preference is not to. In general we only add FW_CONFIG items if they can't be derived or probed otherwise, or affect boot performance.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If74c3649d4e8d174d9fe00a4b896c2351ee3ab19
Gerrit-Change-Number: 74102
Gerrit-PatchSet: 21
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 15:18:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment