Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54353 )
Change subject: mainboard: Drop useless `acpi_tables.c` files ......................................................................
mainboard: Drop useless `acpi_tables.c` files
The `tcrt` and `tpsv` values in GNVS can be used to implement thermal management in ACPI. However, not all mainboards use these values.
On mainboards where `tcrt` and `tpsv` are not used in ACPI tables and are the only values set in the `mainboard_fill_gnvs` function, remove them as well as the entire `acpi_tables.c` file. Most files come from autoport, which unconditionally generates this file.
Change-Id: If2315ddd9700e2da0a24ffecc20acb5c1a1d688e Signed-off-by: Angel Pons th3fanbus@gmail.com --- D src/mainboard/asrock/b75pro3-m/acpi_tables.c D src/mainboard/asrock/b85m_pro4/acpi_tables.c D src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c D src/mainboard/asus/p8h61-m_pro/acpi_tables.c D src/mainboard/asus/p8z77-m_pro/acpi_tables.c D src/mainboard/asus/p8z77-v_lx2/acpi_tables.c D src/mainboard/compulab/intense_pc/acpi_tables.c D src/mainboard/dell/optiplex_9010/acpi_tables.c D src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c D src/mainboard/hp/z220_sff_workstation/acpi_tables.c D src/mainboard/msi/ms7707/acpi_tables.c D src/mainboard/sapphire/pureplatinumh61/acpi_tables.c D src/mainboard/supermicro/x9scl/acpi_tables.c 13 files changed, 0 insertions(+), 134 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/54353/1
diff --git a/src/mainboard/asrock/b75pro3-m/acpi_tables.c b/src/mainboard/asrock/b75pro3-m/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/asrock/b75pro3-m/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/asrock/b85m_pro4/acpi_tables.c b/src/mainboard/asrock/b85m_pro4/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/asrock/b85m_pro4/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c b/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/asus/p8h61-m_pro/acpi_tables.c b/src/mainboard/asus/p8h61-m_pro/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/asus/p8h61-m_pro/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/asus/p8z77-m_pro/acpi_tables.c b/src/mainboard/asus/p8z77-m_pro/acpi_tables.c deleted file mode 100644 index a4204f1..0000000 --- a/src/mainboard/asus/p8z77-m_pro/acpi_tables.c +++ /dev/null @@ -1,13 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - /* critical temp that will shutdown the pc == 95C degrees */ - gnvs->tcrt = 95; - - /* temp to start throttling the cpu == 85C */ - gnvs->tpsv = 85; -} diff --git a/src/mainboard/asus/p8z77-v_lx2/acpi_tables.c b/src/mainboard/asus/p8z77-v_lx2/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/asus/p8z77-v_lx2/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/compulab/intense_pc/acpi_tables.c b/src/mainboard/compulab/intense_pc/acpi_tables.c deleted file mode 100644 index e8e2657..0000000 --- a/src/mainboard/compulab/intense_pc/acpi_tables.c +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -/* FIXME: check this function. */ -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/dell/optiplex_9010/acpi_tables.c b/src/mainboard/dell/optiplex_9010/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/dell/optiplex_9010/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c b/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/hp/z220_sff_workstation/acpi_tables.c b/src/mainboard/hp/z220_sff_workstation/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/hp/z220_sff_workstation/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/msi/ms7707/acpi_tables.c b/src/mainboard/msi/ms7707/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/msi/ms7707/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c b/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c deleted file mode 100644 index 92b9d1c..0000000 --- a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -} diff --git a/src/mainboard/supermicro/x9scl/acpi_tables.c b/src/mainboard/supermicro/x9scl/acpi_tables.c deleted file mode 100644 index 230584e..0000000 --- a/src/mainboard/supermicro/x9scl/acpi_tables.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi_gnvs.h> -#include <soc/nvs.h> - -void mainboard_fill_gnvs(struct global_nvs *gnvs) -{ - gnvs->tcrt = 100; - gnvs->tpsv = 90; -}