Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57324 )
Change subject: drivers/mipi: Make orientation a property of the mainboard, not the panel ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57324/comment/e09a1775_2d64d663 PS3, Line 7: drivers/mipi: Make orientation a property of the mainboard, not the panel
Line too long
Done
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57324/comment/cb31801e_1d7f9ecf PS3, Line 144: panel
Just a note that by removing 'static' from edp_panel, we need to make sure this pointer won't be ref […]
Yeah I honestly don't really know why I made it static in the first place... I think I just wanted to have the static initializer in the if-block, but in hindsight that was a really ugly way to do that. It's not used outside of this function.