build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59866 )
Change subject: amdfwtool: Add options to separate signed firmwares ......................................................................
Patch Set 1:
(3 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134891): https://review.coreboot.org/c/coreboot/+/59866/comment/a0550d98_7134ae5a PS1, Line 645: signed_rom_fd = open(signed_rom , O_RDWR | O_CREAT | O_TRUNC, 0666); space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134891): https://review.coreboot.org/c/coreboot/+/59866/comment/5d71a0a0_cf246b80 PS1, Line 646: if (signed_rom_fd < 0) { suspect code indent for conditional statements (8, 24)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134891): https://review.coreboot.org/c/coreboot/+/59866/comment/2f406bba_b2c3bcb7 PS1, Line 696: fprintf(stderr, "failed to allocate memory with size %lld\n", (long long)fd_stat.st_size); line over 96 characters