Attention is currently required from: Lee Leahy, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63205 )
Change subject: drivers/intel/fsp1_1/hob.c: Don't use broken FSP macros ......................................................................
Patch Set 1:
(4 comments)
File src/drivers/intel/fsp1_1/hob.c:
https://review.coreboot.org/c/coreboot/+/63205/comment/c8188b87_94dea903 PS1, Line 32: /* TODO: It looks like we violate the const qualifier a lot so use an union to work
'an union' may be misspelled - perhaps 'a union'?
Please fix.
https://review.coreboot.org/c/coreboot/+/63205/comment/1e52cf70_ba95f079 PS1, Line 42: union efi_hob hob = { .header = parent } ;
space prohibited before semicolon
Please fix.
https://review.coreboot.org/c/coreboot/+/63205/comment/b83d42d7_4b53acbd PS1, Line 59: union efi_hob hob = { .header = hob_start };
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/63205/comment/027cb118_79698cca PS1, Line 244: void *hob = NULL;;
Statements terminations use 1 semicolon
Please fix.
-
Angel Pons (Code Review)