Change in coreboot[master]: util/board_status/board_status.sh: absorb and inject user identificat... - coreboot-gerrit

2 Feb 2021


      Attention is currently required from: David Hendricks, Paul Menzel.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49311 )
Change subject: util/board_status/board_status.sh: absorb and inject user identification from the top-level git directory
......................................................................
Patch Set 7:
(1 comment)
File util/board_status/board_status.sh:
https://review.coreboot.org/c/coreboot/+/49311/comment/35ec0be1_7529be2b 
PS7, Line 524: 	git_username="$(git config -f .git/config user.name)"
...
What if the user set up their git configuration globally instead of locally, or didn't set these at  […]
Which one should have precendence, the local settings?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49311
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I385f10bffc797db691be1a9109af5336bc8601e3
Gerrit-Change-Number: 49311
Gerrit-PatchSet: 7
Gerrit-Owner: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Feb 2021 19:58:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks david.hendricks@gmail.com
Gerrit-MessageType: comment