Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Ravindra, Mark Hsieh, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61586 )
Change subject: soc/intel/alderlake, mb/google/brya: Update Type-C USB2 port config
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/alderlake/include/soc/usb.h:
https://review.coreboot.org/c/coreboot/+/61586/comment/d771973d_f6ff4a21
PS6, Line 98: #define USB2_PORT_MAX_TYPE_C(pin) { \
: .enable = 1, \
: .ocpin = (pin), \
: .tx_bias = USB2_BIAS_56P3MV, \
: .tx_emp_enable = USB2_PRE_EMP_ON, \
: .pre_emp_bias = USB2_BIAS_56P3MV, \
: .pre_emp_bit = USB2_HALF_BIT_PRE_EMP, \
: .type_c = 1, \
: }
:
I guess we could split this into two macros, […]
Since there are consumers (across Brya family boards) of USB2_PORT_MAX, so I removed the macro intentionally. I think this is ok.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If54faa63a983c859bf26a6a779751a6c3c85c43d
Gerrit-Change-Number: 61586
Gerrit-PatchSet: 6
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravindra
ravindra@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Ravindra
ravindra@intel.com
Gerrit-Attention: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Feb 2022 05:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment