Change in coreboot[master]: mb/google/drallion: Set UART for console to UART controller 0
Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35633 )
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
mb/google/drallion: Set UART for console to UART controller 0
Drallion uses UART 0 for console, change the config accordindly.
Change-Id: I0ae2f8459b6225b99b758180413afa22386355d4 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/drallion/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/35633/1
diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index a2ed3d8..97d0b51 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -91,7 +91,7 @@
config UART_FOR_CONSOLE int - default 2 + default 0
config VARIANT_DIR string
Hello EricR Lai, Selma Bensaid, Bora Guvendik, build bot (Jenkins), Chiranjeevi Rapolu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35633
to look at the new patch set (#2).
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
mb/google/drallion: Set UART for console to UART controller 0
Drallion uses UART 0 for console, change the config accordindly.
BUG=b:139095062
Change-Id: I0ae2f8459b6225b99b758180413afa22386355d4 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/drallion/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/35633/2
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35633 )
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
Patch Set 2: Code-Review+2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35633 )
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
Patch Set 2: Code-Review+2
Hello EricR Lai, Selma Bensaid, Bora Guvendik, build bot (Jenkins), Chiranjeevi Rapolu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35633
to look at the new patch set (#3).
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
mb/google/drallion: Set UART for console to UART controller 0
Drallion uses UART 0 for console, change the config accordindly.
Change-Id: I0ae2f8459b6225b99b758180413afa22386355d4 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/drallion/Kconfig M src/mainboard/google/drallion/variants/drallion/devicetree.cb 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/35633/3
Hello EricR Lai, Selma Bensaid, Bora Guvendik, build bot (Jenkins), Chiranjeevi Rapolu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35633
to look at the new patch set (#4).
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
mb/google/drallion: Set UART for console to UART controller 0
Drallion uses UART 0 for console, change the config accordindly.
BUG=b:139095062
Change-Id: I0ae2f8459b6225b99b758180413afa22386355d4 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/drallion/Kconfig M src/mainboard/google/drallion/variants/drallion/devicetree.cb 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/35633/4
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35633 )
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
Patch Set 4: Code-Review+2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35633 )
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35633 )
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
mb/google/drallion: Set UART for console to UART controller 0
Drallion uses UART 0 for console, change the config accordindly.
BUG=b:139095062
Change-Id: I0ae2f8459b6225b99b758180413afa22386355d4 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35633 Reviewed-by: Bora Guvendik bora.guvendik@intel.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/drallion/Kconfig M src/mainboard/google/drallion/variants/drallion/devicetree.cb 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Bora Guvendik: Looks good to me, approved EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index a2ed3d8..97d0b51 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -91,7 +91,7 @@
config UART_FOR_CONSOLE int - default 2 + default 0
config VARIANT_DIR string diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index d824a55..956e54e 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -389,7 +389,7 @@ end end # I2C #4 device pci 19.1 off end # I2C #5 - device pci 19.2 on end # UART #2 + device pci 19.2 off end # UART #2 device pci 1a.0 off end # eMMC device pci 1c.0 off end # PCI Express Port 1 (USB) device pci 1c.1 off end # PCI Express Port 2 (USB) @@ -408,7 +408,7 @@ device pci 1d.4 on smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "2280" "SlotDataBusWidth4X" end # PCI Express Port 13 (x4) - device pci 1e.0 off end # UART #0 + device pci 1e.0 on end # UART #0 device pci 1e.1 off end # UART #1 device pci 1e.2 off end # GSPI #0 device pci 1e.3 off end # GSPI #1
Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35633 )
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35633/5/src/mainboard/google/dralli... File src/mainboard/google/drallion/Kconfig:
https://review.coreboot.org/c/coreboot/+/35633/5/src/mainboard/google/dralli... PS5, Line 94: default 0 Could we add the following change to avoid affecting arcada_cml and sarien_cml builds?
config UART_FOR_CONSOLE int - default 0 + default 2 if BOARD_GOOGLE_ARCADA_CML + default 2 if BOARD_GOOGLE_SARIEN_CML + default 0 if BOARD_GOOGLE_DRALLION
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35633 )
Change subject: mb/google/drallion: Set UART for console to UART controller 0 ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35633/5/src/mainboard/google/dralli... File src/mainboard/google/drallion/Kconfig:
https://review.coreboot.org/c/coreboot/+/35633/5/src/mainboard/google/dralli... PS5, Line 94: default 0
Could we add the following change to avoid affecting arcada_cml and sarien_cml builds? […]
Yes Bernardo, can you please push a patch for that.
-
Aamir Bohra (Code Review) -
Bernardo Perez Priego (Code Review)
-
Bora Guvendik (Code Review)
-
EricR Lai (Code Review)
-
Patrick Georgi (Code Review)