Change in ...coreboot[master]: mb/lenovo/t430: Add support for MRC raminit

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in em100[master]: Makefile:...

Petr K (Code Review)

16 Jun 2019 16 Jun '19

2:04 p.m.

Petr K has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33539

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

mb/lenovo/t430: Add support for MRC raminit

Add support for MRC raminit and fill PEI data to make ports work. Based on 32500

Signed-off-by: Petr K piotrkloc94@hotmail.com Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 --- M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t430/romstage.c 3 files changed, 43 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/33539/1

diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig index 7137b5e..7e52967 100644 --- a/src/mainboard/lenovo/t430/Kconfig +++ b/src/mainboard/lenovo/t430/Kconfig @@ -19,7 +19,6 @@ select SERIRQ_CONTINUOUS_MODE select SOUTHBRIDGE_INTEL_C216 select SYSTEM_TYPE_LAPTOP - select USE_NATIVE_RAMINIT select DRIVERS_LENOVO_HYBRID_GRAPHICS select MAINBOARD_HAS_LIBGFXINIT select GFX_GMA_INTERNAL_IS_LVDS diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index 2731b69..a992377 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -30,6 +30,32 @@ end end

+ # PEI data + + register "spd_addresses" = "{ 0xa0, 0x00, 0xa2, 0x00 }" + register "ts_addresses" = "{ 0x00, 0x00, 0x00, 0x00 }" + + register "max_mem_clock_mhz" = "800" # DDR3-1600 + + register "usb_port_config" = "{ + + { 1, 1, 0x0040 }, + { 1, 1, 0x0040 }, + { 1, 2, 0x0040 }, + { 1, 1, 0x0040 }, + { 1, 1, 0x0040 }, + { 1, 0, 0x0040 }, + { 0, 0, 0x0040 }, + { 1, 2, 0x0040 }, + { 1, 0, 0x0040 }, + { 1, 1, 0x0040 }, + { 1, 0, 0x0040 }, + { 1, 0, 0x0040 }, + { 1, 3, 0x0040 }, + { 1, 1, 0x0040 }, + + }" + device domain 0x0 on chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH register "c2_latency" = "0x0065" diff --git a/src/mainboard/lenovo/t430/romstage.c b/src/mainboard/lenovo/t430/romstage.c index db50bb3..fa46dc3 100644 --- a/src/mainboard/lenovo/t430/romstage.c +++ b/src/mainboard/lenovo/t430/romstage.c @@ -20,6 +20,7 @@ #include <ec/lenovo/pmh7/pmh7.h> #include <drivers/lenovo/hybrid_graphics/hybrid_graphics.h> #include <northbridge/intel/sandybridge/sandybridge.h> +#include <northbridge/intel/sandybridge/raminit.h> #include <device/device.h> #include <device/pci.h>

@@ -96,3 +97,19 @@ read_spd(&spd[0], 0x50, id_only); read_spd(&spd[2], 0x51, id_only); } + + +void mainboard_fill_pei_data(struct pei_data *pei_data) + +{ + +} + + +int mainboard_should_reset_usb(int s3resume) + +{ + + return !s3resume; + +}

Attachments:

attachment.htm (text/html — 6.9 KB)

Show replies by date

build bot (Jenkins) (Code Review)

16 Jun 16 Jun

2:04 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 1:

(14 comments)

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/devicetree... File src/mainboard/lenovo/t430/devicetree.cb:

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/devicetree... PS1, Line 34: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/devicetree... PS1, Line 37: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/devicetree... PS1, Line 39: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/devicetree... PS1, Line 41: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/devicetree... PS1, Line 56: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/devicetree... PS1, Line 58: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/romstage.c File src/mainboard/lenovo/t430/romstage.c:

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/romstage.c... PS1, Line 101: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/romstage.c... PS1, Line 103: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/romstage.c... PS1, Line 105: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/romstage.c... PS1, Line 107: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/romstage.c... PS1, Line 108: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/romstage.c... PS1, Line 110: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/romstage.c... PS1, Line 112: trailing whitespace

https://review.coreboot.org/#/c/33539/1/src/mainboard/lenovo/t430/romstage.c... PS1, Line 114: trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 1 Gerrit-Owner: Petr K Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 16 Jun 2019 12:04:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Petr K (Code Review)

6:04 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33539

to look at the new patch set (#3).

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

mb/lenovo/t430: Add support for MRC raminit

Add support for MRC raminit and fill PEI data to make ports work. Based on 32500

Signed-off-by: Piotr Kloc piotrkloc94@hotmail.com Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 --- M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t430/romstage.c 3 files changed, 43 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/33539/3

build bot (Jenkins) (Code Review)

6:04 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 2:

(14 comments)

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/devicetree... File src/mainboard/lenovo/t430/devicetree.cb:

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/devicetree... PS2, Line 34: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/devicetree... PS2, Line 37: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/devicetree... PS2, Line 39: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/devicetree... PS2, Line 41: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/devicetree... PS2, Line 56: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/devicetree... PS2, Line 58: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/romstage.c File src/mainboard/lenovo/t430/romstage.c:

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/romstage.c... PS2, Line 101: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/romstage.c... PS2, Line 103: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/romstage.c... PS2, Line 105: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/romstage.c... PS2, Line 107: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/romstage.c... PS2, Line 108: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/romstage.c... PS2, Line 110: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/romstage.c... PS2, Line 112: trailing whitespace

https://review.coreboot.org/#/c/33539/2/src/mainboard/lenovo/t430/romstage.c... PS2, Line 114: trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 2 Gerrit-Owner: Petr K Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 16 Jun 2019 16:04:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Petr K (Code Review)

6:21 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33539

to look at the new patch set (#4).

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

mb/lenovo/t430: Add support for MRC raminit

Add support for MRC raminit and fill PEI data to make ports work. Based on 32500

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/33539/4

Petr K (Code Review)

7:12 p.m.

Hello Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33539

to look at the new patch set (#5).

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

mb/lenovo/t430: Add support for MRC raminit

Add support for MRC raminit and fill PEI data to make ports work. Based on 32500

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/33539/5

Angel Pons (Code Review)

7:15 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 5: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/33539/5/src/mainboard/lenovo/t430/devicetree... File src/mainboard/lenovo/t430/devicetree.cb:

https://review.coreboot.org/#/c/33539/5/src/mainboard/lenovo/t430/devicetree... PS5, Line 53: }" One tab too much

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 5 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 16 Jun 2019 17:15:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Petr K (Code Review)

7:23 p.m.

Hello Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33539

to look at the new patch set (#6).

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

mb/lenovo/t430: Add support for MRC raminit

Add support for MRC raminit and fill PEI data to make ports work. Based on 32500

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/33539/6

Angel Pons (Code Review)

7:26 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 6: Code-Review+1

Looks good, depends on other patches to be merged in first though.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 6 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 16 Jun 2019 17:26:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Petr K (Code Review)

7:33 p.m.

Petr K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 6:

...

Patch Set 6: Code-Review+1

Looks good, depends on other patches to be merged in first though.

Well, it does work right now.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 6 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Petr K Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 16 Jun 2019 17:33:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Philipp Deppenwiese (Code Review)

17 Jun 17 Jun

12:39 a.m.

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 6: Code-Review-1

Does the native raminit doesn't work???

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 6 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Petr K Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Sun, 16 Jun 2019 22:39:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

12:54 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 6:

...

Patch Set 6: Code-Review-1

Does the native raminit doesn't work???

Native raminit works, but on some weird corner cases, it fails and falls back to single-channel. This patch does not disable native raminit for this board, it unselects it so that one can choose in menuconfig.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 6 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Petr K Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Sun, 16 Jun 2019 22:54:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Philipp Deppenwiese (Code Review)

12:58 a.m.

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 6: -Code-Review

Got it

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 6 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Petr K Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Sun, 16 Jun 2019 22:58:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Petr K (Code Review)

6:18 p.m.

Petr K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 6:

Unfortunately I'm affected by this issue, hence the patch.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 6 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Petr K Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Mon, 17 Jun 2019 16:18:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

18 Jun 18 Jun

9:04 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/33539/6/src/mainboard/lenovo/t430/romstage.c File src/mainboard/lenovo/t430/romstage.c:

https://review.coreboot.org/#/c/33539/6/src/mainboard/lenovo/t430/romstage.c... PS6, Line 101: void mainboard_fill_pei_data(struct pei_data *pei_data) needs to be filled with sane values

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 6 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Petr K Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Tue, 18 Jun 2019 07:04:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Petr K (Code Review)

22 Nov 22 Nov

7:16 p.m.

New subject: Change in coreboot[master]: mb/lenovo/t430: Add support for MRC raminit

Hello Angel Pons, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33539

to look at the new patch set (#7).

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

mb/lenovo/t430: Add support for MRC raminit

Add support for MRC raminit and fill PEI data to make ports work. Based on 32500

Signed-off-by: Piotr Kloc piotrkloc94@hotmail.com Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 --- M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430/devicetree.cb R src/mainboard/lenovo/t430/early_init.c 3 files changed, 32 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/33539/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 7 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Petr K Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: newpatchset

Petr K (Code Review)

7:34 p.m.

New subject: Change in coreboot[master]: mb/lenovo/t430: Add support for MRC raminit

Petr K has removed Alexander Couzens from this change. ( https://review.coreboot.org/c/coreboot/+/33539 )

Change subject: mb/lenovo/t430: Add support for MRC raminit ......................................................................

Removed reviewer Alexander Couzens.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e097f7bb6b1de55b9e6a84efa4f9c630cee0745 Gerrit-Change-Number: 33539 Gerrit-PatchSet: 7 Gerrit-Owner: Petr K Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Petr K Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: deleteReviewer

1819

days inactive

1978

days old

coreboot-gerrit@coreboot.org

16 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
build bot (Jenkins) (Code Review)
Patrick Rudolph (Code Review)
Petr K (Code Review)
Philipp Deppenwiese (Code Review)