Attention is currently required from: Raul Rangel, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66761 )
Change subject: util/amdfwtool/amdfwread: List AMDFW RO binary entries ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66761/comment/67106769_c5c67813 PS4, Line 17: TEST=Build and list the contents of AMDFW binary.
Can you include a example of the output?
Done
File util/amdfwtool/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/66761/comment/333cd9c3_fd11b3b6 PS4, Line 282: current_entries
Is it possible to have more entries after `AMD_FW_L2_PTR`? i.e. […]
So far our assumption holds true i.e AMD_FW_L2_PTR is the last entry in the PSP L1 table. But I am not sure if that assumption will hold true forever. From the output standpoint we are not going to miss any entries. Rather L2 entries will be interspersed with L1 entries. So it is a matter of convenience over correctness.
https://review.coreboot.org/c/coreboot/+/66761/comment/2cee473b_1e32d63c PS4, Line 289: AMD_FW_RECOVERYAB_A
Can we print an indication describing if something is in the A or B table?
Atleast in ChromeOS, Table A and Table B point to the same PSP L2 directory to save space. So I just am parsing Table A at the moment. Please let me know if you want to print TableB too for completion?
-
Karthik Ramasubramanian (Code Review)