Attention is currently required from: Jamie Chen, Henry Sun, Tim Wawrzynczak, Paul Menzel, Ren Kuo, Simon Yang, Kane Chen, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60009 )
Change subject: soc/intel/jsl: Add CdClock config
......................................................................
Patch Set 16: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60009/comment/33731f0f_b84f7e8c
PS16, Line 7: CdClock
nit: `CdClock frequency`
https://review.coreboot.org/c/coreboot/+/60009/comment/811022c0_1fc010c3
PS16, Line 9: This dev tree config controls the CdClock for Jasper Lake.
I'd reword and expand this a bit, stating what `CdClock` means and removing the redundant `for Jasper Lake` part (already in the summary as `soc/intel/jsl`):
Add a devicetree setting to configure the CdClock (Core Display Clock)
frequency through a FSP UPD. Because the value for this UPD's default
setting is non-zero and devicetree settings default to 0 if not set,
adapt the devicetree values so that the value for the UPD's default
setting is used when the devicetree setting is zero.
Patchset:
PS16:
After addressing my comments, LGTM.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60009
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I917c2f10b130b0cd54f60e2ba98eb971d5ec3c97
Gerrit-Change-Number: 60009
Gerrit-PatchSet: 16
Gerrit-Owner: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 23 Dec 2021 11:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment