HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41491 )
Change subject: src: Remove unused '#include <timer.h>' ......................................................................
src: Remove unused '#include <timer.h>'
Change-Id: I57e064d26b215743a1cb06bb6605fc4fe1160876 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/analogix/anx7625/anx7625.c M src/drivers/intel/ptt/ptt.c M src/soc/amd/common/block/psp/psp.c M src/soc/amd/common/block/psp/psp_smm.c M src/soc/amd/picasso/finalize.c M src/soc/amd/stoneyridge/finalize.c M src/soc/intel/skylake/cpu.c M src/soc/intel/skylake/finalize.c M src/soc/mediatek/mt8173/i2c.c M src/soc/qualcomm/sc7180/gpio.c 10 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/41491/1
diff --git a/src/drivers/analogix/anx7625/anx7625.c b/src/drivers/analogix/anx7625/anx7625.c index 57f1c77..ee98fd4 100644 --- a/src/drivers/analogix/anx7625/anx7625.c +++ b/src/drivers/analogix/anx7625/anx7625.c @@ -5,7 +5,6 @@ #include <device/i2c_simple.h> #include <edid.h> #include <gpio.h> -#include <timer.h> #include <string.h>
#include "anx7625.h" diff --git a/src/drivers/intel/ptt/ptt.c b/src/drivers/intel/ptt/ptt.c index 91eb42c..67ed0ee 100644 --- a/src/drivers/intel/ptt/ptt.c +++ b/src/drivers/intel/ptt/ptt.c @@ -3,7 +3,6 @@ #include <soc/pci_devs.h> #include <device/pci_ops.h> #include <console/console.h> -#include <timer.h>
#include "ptt.h"
diff --git a/src/soc/amd/common/block/psp/psp.c b/src/soc/amd/common/block/psp/psp.c index b1b8b0d..0e03174 100644 --- a/src/soc/amd/common/block/psp/psp.c +++ b/src/soc/amd/common/block/psp/psp.c @@ -2,7 +2,6 @@
#include <device/mmio.h> #include <cpu/x86/msr.h> -#include <timer.h> #include <bootstate.h> #include <console/console.h> #include <amdblocks/psp.h> diff --git a/src/soc/amd/common/block/psp/psp_smm.c b/src/soc/amd/common/block/psp/psp_smm.c index 4fd80fc..024e952 100644 --- a/src/soc/amd/common/block/psp/psp_smm.c +++ b/src/soc/amd/common/block/psp/psp_smm.c @@ -5,7 +5,6 @@ #include <cpu/amd/msr.h> #include <cbfs.h> #include <region_file.h> -#include <timer.h> #include <bootstate.h> #include <rules.h> #include <console/console.h> diff --git a/src/soc/amd/picasso/finalize.c b/src/soc/amd/picasso/finalize.c index 0df94468..2df5524 100644 --- a/src/soc/amd/picasso/finalize.c +++ b/src/soc/amd/picasso/finalize.c @@ -5,7 +5,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/msr.h> #include <bootstate.h> -#include <timer.h> #include <console/console.h> #include <amdblocks/acpi.h>
diff --git a/src/soc/amd/stoneyridge/finalize.c b/src/soc/amd/stoneyridge/finalize.c index 0df94468..2df5524 100644 --- a/src/soc/amd/stoneyridge/finalize.c +++ b/src/soc/amd/stoneyridge/finalize.c @@ -5,7 +5,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/msr.h> #include <bootstate.h> -#include <timer.h> #include <console/console.h> #include <amdblocks/acpi.h>
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c index 1aba7f6..4b319e6 100644 --- a/src/soc/intel/skylake/cpu.c +++ b/src/soc/intel/skylake/cpu.c @@ -26,7 +26,6 @@ #include <soc/pm.h> #include <soc/ramstage.h> #include <soc/systemagent.h> -#include <timer.h>
#include "chip.h"
diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index ba154f2..b20f391 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -24,7 +24,6 @@ #include <soc/pm.h> #include <soc/smbus.h> #include <soc/systemagent.h> -#include <timer.h>
#include "chip.h"
diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c index d2acd2c..0adee22 100644 --- a/src/soc/mediatek/mt8173/i2c.c +++ b/src/soc/mediatek/mt8173/i2c.c @@ -5,7 +5,6 @@ #include <delay.h> #include <device/i2c_simple.h> #include <symbols.h> -#include <timer.h> #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/i2c.h> diff --git a/src/soc/qualcomm/sc7180/gpio.c b/src/soc/qualcomm/sc7180/gpio.c index 9588cc1..51d9135 100644 --- a/src/soc/qualcomm/sc7180/gpio.c +++ b/src/soc/qualcomm/sc7180/gpio.c @@ -3,7 +3,6 @@ #include <assert.h> #include <delay.h> #include <device/mmio.h> -#include <timer.h> #include <timestamp.h> #include <types.h>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41491 )
Change subject: src: Remove unused '#include <timer.h>' ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41491 )
Change subject: src: Remove unused '#include <timer.h>' ......................................................................
src: Remove unused '#include <timer.h>'
Change-Id: I57e064d26b215743a1cb06bb6605fc4fe1160876 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41491 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/analogix/anx7625/anx7625.c M src/drivers/intel/ptt/ptt.c M src/soc/amd/common/block/psp/psp.c M src/soc/amd/common/block/psp/psp_smm.c M src/soc/amd/picasso/finalize.c M src/soc/amd/stoneyridge/finalize.c M src/soc/intel/skylake/cpu.c M src/soc/intel/skylake/finalize.c M src/soc/mediatek/mt8173/i2c.c M src/soc/qualcomm/sc7180/gpio.c 10 files changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/drivers/analogix/anx7625/anx7625.c b/src/drivers/analogix/anx7625/anx7625.c index 57f1c77..ee98fd4 100644 --- a/src/drivers/analogix/anx7625/anx7625.c +++ b/src/drivers/analogix/anx7625/anx7625.c @@ -5,7 +5,6 @@ #include <device/i2c_simple.h> #include <edid.h> #include <gpio.h> -#include <timer.h> #include <string.h>
#include "anx7625.h" diff --git a/src/drivers/intel/ptt/ptt.c b/src/drivers/intel/ptt/ptt.c index 91eb42c..67ed0ee 100644 --- a/src/drivers/intel/ptt/ptt.c +++ b/src/drivers/intel/ptt/ptt.c @@ -3,7 +3,6 @@ #include <soc/pci_devs.h> #include <device/pci_ops.h> #include <console/console.h> -#include <timer.h>
#include "ptt.h"
diff --git a/src/soc/amd/common/block/psp/psp.c b/src/soc/amd/common/block/psp/psp.c index b1b8b0d..0e03174 100644 --- a/src/soc/amd/common/block/psp/psp.c +++ b/src/soc/amd/common/block/psp/psp.c @@ -2,7 +2,6 @@
#include <device/mmio.h> #include <cpu/x86/msr.h> -#include <timer.h> #include <bootstate.h> #include <console/console.h> #include <amdblocks/psp.h> diff --git a/src/soc/amd/common/block/psp/psp_smm.c b/src/soc/amd/common/block/psp/psp_smm.c index 4fd80fc..024e952 100644 --- a/src/soc/amd/common/block/psp/psp_smm.c +++ b/src/soc/amd/common/block/psp/psp_smm.c @@ -5,7 +5,6 @@ #include <cpu/amd/msr.h> #include <cbfs.h> #include <region_file.h> -#include <timer.h> #include <bootstate.h> #include <rules.h> #include <console/console.h> diff --git a/src/soc/amd/picasso/finalize.c b/src/soc/amd/picasso/finalize.c index 0df94468..2df5524 100644 --- a/src/soc/amd/picasso/finalize.c +++ b/src/soc/amd/picasso/finalize.c @@ -5,7 +5,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/msr.h> #include <bootstate.h> -#include <timer.h> #include <console/console.h> #include <amdblocks/acpi.h>
diff --git a/src/soc/amd/stoneyridge/finalize.c b/src/soc/amd/stoneyridge/finalize.c index 0df94468..2df5524 100644 --- a/src/soc/amd/stoneyridge/finalize.c +++ b/src/soc/amd/stoneyridge/finalize.c @@ -5,7 +5,6 @@ #include <cpu/x86/msr.h> #include <cpu/amd/msr.h> #include <bootstate.h> -#include <timer.h> #include <console/console.h> #include <amdblocks/acpi.h>
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c index 28572e5..845becc 100644 --- a/src/soc/intel/skylake/cpu.c +++ b/src/soc/intel/skylake/cpu.c @@ -26,7 +26,6 @@ #include <soc/pm.h> #include <soc/ramstage.h> #include <soc/systemagent.h> -#include <timer.h>
#include "chip.h"
diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index ba154f2..b20f391 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -24,7 +24,6 @@ #include <soc/pm.h> #include <soc/smbus.h> #include <soc/systemagent.h> -#include <timer.h>
#include "chip.h"
diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c index d2acd2c..0adee22 100644 --- a/src/soc/mediatek/mt8173/i2c.c +++ b/src/soc/mediatek/mt8173/i2c.c @@ -5,7 +5,6 @@ #include <delay.h> #include <device/i2c_simple.h> #include <symbols.h> -#include <timer.h> #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/i2c.h> diff --git a/src/soc/qualcomm/sc7180/gpio.c b/src/soc/qualcomm/sc7180/gpio.c index 9588cc1..51d9135 100644 --- a/src/soc/qualcomm/sc7180/gpio.c +++ b/src/soc/qualcomm/sc7180/gpio.c @@ -3,7 +3,6 @@ #include <assert.h> #include <delay.h> #include <device/mmio.h> -#include <timer.h> #include <timestamp.h> #include <types.h>
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41491 )
Change subject: src: Remove unused '#include <timer.h>' ......................................................................
Patch Set 6:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4560 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4559 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4558 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4557
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)