Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70149 )
Change subject: nb/intel/i945: Use boolean for gpu_lvds_use_spread_spectrum_clock ......................................................................
nb/intel/i945: Use boolean for gpu_lvds_use_spread_spectrum_clock
Change-Id: I5f11bde99dfcde81c9dc62c1102330c0a6c16e04 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/70149 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/apple/macbook21/devicetree.cb M src/mainboard/lenovo/t60/devicetree.cb M src/mainboard/lenovo/x60/devicetree.cb M src/northbridge/intel/i945/chip.h 4 files changed, 18 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/apple/macbook21/devicetree.cb b/src/mainboard/apple/macbook21/devicetree.cb index 833d658..a7832ef 100644 --- a/src/mainboard/apple/macbook21/devicetree.cb +++ b/src/mainboard/apple/macbook21/devicetree.cb @@ -5,7 +5,7 @@ register "gfx" = "GMA_STATIC_DISPLAYS(0)"
register "gpu_hotplug" = "0x00000220" - register "gpu_lvds_use_spread_spectrum_clock" = "1" + register "gpu_lvds_use_spread_spectrum_clock" = "true" register "pwm_freq" = "180" register "gpu_panel_power_up_delay" = "250" register "gpu_panel_power_backlight_on_delay" = "2380" diff --git a/src/mainboard/lenovo/t60/devicetree.cb b/src/mainboard/lenovo/t60/devicetree.cb index c77af6b..7a9e9ae 100644 --- a/src/mainboard/lenovo/t60/devicetree.cb +++ b/src/mainboard/lenovo/t60/devicetree.cb @@ -5,7 +5,7 @@ register "gfx" = "GMA_STATIC_DISPLAYS(0)"
register "gpu_hotplug" = "0x00000220" - register "gpu_lvds_use_spread_spectrum_clock" = "1" + register "gpu_lvds_use_spread_spectrum_clock" = "true" register "pwm_freq" = "275" register "gpu_panel_power_up_delay" = "250" register "gpu_panel_power_backlight_on_delay" = "2380" diff --git a/src/mainboard/lenovo/x60/devicetree.cb b/src/mainboard/lenovo/x60/devicetree.cb index d56ec51..a41749a 100644 --- a/src/mainboard/lenovo/x60/devicetree.cb +++ b/src/mainboard/lenovo/x60/devicetree.cb @@ -5,7 +5,7 @@ register "gfx" = "GMA_STATIC_DISPLAYS(0)"
register "gpu_hotplug" = "0x00000220" - register "gpu_lvds_use_spread_spectrum_clock" = "1" + register "gpu_lvds_use_spread_spectrum_clock" = "true" register "pwm_freq" = "180" register "gpu_panel_power_up_delay" = "250" register "gpu_panel_power_backlight_on_delay" = "2380" diff --git a/src/northbridge/intel/i945/chip.h b/src/northbridge/intel/i945/chip.h index 0de0e58..8153462 100644 --- a/src/northbridge/intel/i945/chip.h +++ b/src/northbridge/intel/i945/chip.h @@ -4,6 +4,7 @@ #define NORTHBRIDGE_INTEL_I945_CHIP_H
#include <drivers/intel/gma/i915.h> +#include <types.h>
struct northbridge_intel_i945_config { /* In units of 100us timer */ @@ -17,7 +18,7 @@
u32 gpu_hotplug; u32 pwm_freq; - int gpu_lvds_use_spread_spectrum_clock; + bool gpu_lvds_use_spread_spectrum_clock; struct i915_gpu_controller_info gfx; int pci_mmio_size; };