Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18011 )
Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ......................................................................
Patch Set 8: Code-Review+2
(5 comments)
https://review.coreboot.org/#/c/18011/8/src/mainboard/lenovo/t430/Kconfig File src/mainboard/lenovo/t430/Kconfig:
PS8, Line 44: config VGA_BIOS_FILE : string : default "pci8086,0166.rom" not needed when VGA_BIOS_ID is set.
PS8, Line 76: config ONBOARD_VGA_IS_PRIMARY : bool : default y Is this so that hybrid driver can do its job without allocator .disable function messing things up?
https://review.coreboot.org/#/c/18011/8/src/mainboard/lenovo/t430/devicetree... File src/mainboard/lenovo/t430/devicetree.cb:
PS8, Line 18: 0x11551155 suggestion: maybe set default duty cycle a bit lower since full can be blinding in the dark. 70% maybe: 0x11550c08 ?
https://review.coreboot.org/#/c/18011/8/src/mainboard/lenovo/t430/gpio.c File src/mainboard/lenovo/t430/gpio.c:
Line 17: const struct pch_gpio_set1 pch_gpio_set1_mode = { empty line between header?
https://review.coreboot.org/#/c/18011/8/src/mainboard/lenovo/t430/thermal.h File src/mainboard/lenovo/t430/thermal.h:
PS8, Line 21: tabs ?