Attention is currently required from: Ivy Jian, Karthik Ramasubramanian, Nick Vaccaro.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79391?usp=email )
Change subject: mb/google/brox: Update configuration for USB ports ......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79391/comment/aeb2e0f8_90bfe2c8 : PS1, Line 31: OC_SKIP OC2 here as well?
https://review.coreboot.org/c/coreboot/+/79391/comment/d4a782e2_2d06da1a : PS1, Line 33: OC_SKIP Is this supposed to be OC1? I see that in the schematics USB_OC1_L is attached to USB_A0_OC_ODL.
https://review.coreboot.org/c/coreboot/+/79391/comment/859c1c9c_7a36642b : PS1, Line 36: DCI Is this Type A port A0? Also should it be OC1 like previous comment above?