Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29104 )
Change subject: sdm845: Port I2C driver ......................................................................
Patch Set 38: Code-Review+2
(2 comments)
Still entangled with other patches a bit but I guess it's good enough to merge now.
https://review.coreboot.org/c/coreboot/+/29104/38/src/mainboard/google/cheza... File src/mainboard/google/cheza/mainboard.c:
https://review.coreboot.org/c/coreboot/+/29104/38/src/mainboard/google/cheza... PS38, Line 23: #include <soc/i2c.h> Should be in the patch that adds the i2c_init(), not this one.
https://review.coreboot.org/c/coreboot/+/29104/38/src/soc/qualcomm/sdm845/sp... File src/soc/qualcomm/sdm845/spi_qup.c:
https://review.coreboot.org/c/coreboot/+/29104/38/src/soc/qualcomm/sdm845/sp... PS38, Line 46: Merge mistake (I2C patch shouldn't touch this file).
-
Julius Werner (Code Review)