Attention is currently required from: Arthur Heymans, Cliff Huang, David Ruth, Eric Lai, Kapil Porwal, Lance Zhao, Nick Vaccaro, Nico Huber, Paul Menzel, Subrata Banik, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email )
Change subject: drivers/wifi: Add MTCL function to ACPI SSDT
......................................................................
Patch Set 17:
(2 comments)
Patchset:
PS14:
Added configs/config.google_yaviks_cros, along with a comment describing how I did it, and why it should build test this feature (by making USE_MTCL a default for BOARD_GOOGLE_YAVIKS).
if config change is required then that can be submitted a separate CL. It's not much have to share the .config change for all CL. Atleast I haven't seen this practice.
Patchset:
PS17:
Config change was done as requested at https://review.coreboot.org/c/coreboot/+/80170/comments/15f78669_14a94a7f.
I can split the mainboard change out, but if I do, I'd rather also make the config change in that change.
i would say, please submit this CL as base then submit the mb cl on top of the base cl. finally, you can upload the .config as requested by Nico.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80170?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9b5e7312a44e114270e664b983626faa6cfee350
Gerrit-Change-Number: 80170
Gerrit-PatchSet: 17
Gerrit-Owner: David Ruth
druth@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: David Ruth
druth@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 01 Feb 2024 17:25:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: David Ruth
druth@chromium.org
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment