[XS] Change in coreboot[main]: mb/google/nissa: Fix potential null pointer dereference

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/82628?usp=email )

Change subject: mb/google/nissa: Fix potential null pointer dereference
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/82628/comment/28eaebee_183a44b2?usp... :
PS1, Line 7: mb/google/brya/var/bb/nissa
> mb/google/nissa is enough for consistent.

Acknowledged

File src/mainboard/google/brya/variants/baseboard/nissa/ramstage.c:

https://review.coreboot.org/c/coreboot/+/82628/comment/a1229b44_a6faa573?usp... :
PS1, Line 19: 	if (override_pads != NULL)
> As long as the override_num is 0 is fine. I think if we return NULL the number will set to 0, but good to have check.
>
> void gpio_padbased_override(struct pad_config *padbased_table,
>    			const struct pad_config *override_cfg,
>    			size_t override_num_pads)
> {
>    for (size_t i = 0; i < override_num_pads; i++) {
>    	/* Prevent overflow hack */
>    	ASSERT(override_cfg[i].pad < TOTAL_PADS);
>    	padbased_table[override_cfg[i].pad] = override_cfg[i];
>    }
> }

i agree but it's better to have a check at outer layer to prevent the call. Do you agree ?