HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36598 )
Change subject: superio/winbond/w83627dhg/acpi: Fix IndexField(IndexName, DataName..) ......................................................................
superio/winbond/w83627dhg/acpi: Fix IndexField(IndexName, DataName..)
Change-Id: I64fdcbcbbd54334c1c551bc1346c6000ea82c97d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/winbond/w83627dhg/acpi/superio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36598/1
diff --git a/src/superio/winbond/w83627dhg/acpi/superio.asl b/src/superio/winbond/w83627dhg/acpi/superio.asl index 301ee94..588c476 100644 --- a/src/superio/winbond/w83627dhg/acpi/superio.asl +++ b/src/superio/winbond/w83627dhg/acpi/superio.asl @@ -65,7 +65,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8 } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG,PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x07), PNP_LOGICAL_DEVICE, 8, /* Logical device selector */
Hello Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36598
to look at the new patch set (#2).
Change subject: superio/winbond/w83627dhg/acpi: Fix IndexField(IndexName, DataName..) ......................................................................
superio/winbond/w83627dhg/acpi: Fix IndexField(IndexName, DataName..)
Change-Id: I64fdcbcbbd54334c1c551bc1346c6000ea82c97d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/winbond/w83627dhg/acpi/superio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36598/2
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36598
to look at the new patch set (#3).
Change subject: superio/*/*/acpi: Fix IndexField(IndexName, DataName..) ......................................................................
superio/*/*/acpi: Fix IndexField(IndexName, DataName..)
Change-Id: I64fdcbcbbd54334c1c551bc1346c6000ea82c97d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/fintek/f81803a/acpi/superio.asl M src/superio/ite/it8720f/acpi/superio.asl M src/superio/ite/it8721f/acpi/superio.asl M src/superio/ite/it8783ef/acpi/superio.asl M src/superio/ite/it8786e/acpi/superio.asl M src/superio/nuvoton/nct5539d/acpi/superio.asl M src/superio/nuvoton/nct6776/acpi/superio.asl M src/superio/nuvoton/npcd378/acpi/superio.asl M src/superio/smsc/sch5147/acpi/superio.asl M src/superio/winbond/w83627dhg/acpi/superio.asl 10 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36598/3
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36598
to look at the new patch set (#4).
Change subject: superio/*/*/acpi: Fix the IndexName and DataName of the IndexField ......................................................................
superio/*/*/acpi: Fix the IndexName and DataName of the IndexField
Change-Id: I64fdcbcbbd54334c1c551bc1346c6000ea82c97d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/fintek/f81803a/acpi/superio.asl M src/superio/ite/it8720f/acpi/superio.asl M src/superio/ite/it8721f/acpi/superio.asl M src/superio/ite/it8783ef/acpi/superio.asl M src/superio/ite/it8786e/acpi/superio.asl M src/superio/nuvoton/nct5539d/acpi/superio.asl M src/superio/nuvoton/nct6776/acpi/superio.asl M src/superio/nuvoton/npcd378/acpi/superio.asl M src/superio/smsc/sch5147/acpi/superio.asl M src/superio/winbond/w83627dhg/acpi/superio.asl 10 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36598/4
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36598 )
Change subject: superio/*/*/acpi: Fix the IndexName and DataName of the IndexField ......................................................................
Patch Set 4: Code-Review+1
The ACPI code for w83627hf doesn't use the PNP_ADDR_REG/PNP_DATA_REG defines in the same place yet as well; would be good if you added that to the patch too. I found the commit message a bit misleading; this patch replaces the short names with the longer names that make the code a bit easier to understand, which shouldn't change behavior, since the preprocessor replaces the long names with the short ones anyway. So the current state isn't broken, but your patch definitely improves readability.
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36598
to look at the new patch set (#5).
Change subject: superio/*/*/acpi: Improve readability of the IndexField ......................................................................
superio/*/*/acpi: Improve readability of the IndexField
Change-Id: I64fdcbcbbd54334c1c551bc1346c6000ea82c97d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/fintek/f81803a/acpi/superio.asl M src/superio/ite/it8720f/acpi/superio.asl M src/superio/ite/it8721f/acpi/superio.asl M src/superio/ite/it8783ef/acpi/superio.asl M src/superio/ite/it8786e/acpi/superio.asl M src/superio/nuvoton/nct5539d/acpi/superio.asl M src/superio/nuvoton/nct6776/acpi/superio.asl M src/superio/nuvoton/npcd378/acpi/superio.asl M src/superio/smsc/sch5147/acpi/superio.asl M src/superio/winbond/w83627dhg/acpi/superio.asl M src/superio/winbond/w83627hf/acpi/superio.asl 11 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36598/5
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36598
to look at the new patch set (#6).
Change subject: superio/*/*/acpi: Improve the readability of the IndexField ......................................................................
superio/*/*/acpi: Improve the readability of the IndexField
Change-Id: I64fdcbcbbd54334c1c551bc1346c6000ea82c97d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/fintek/f81803a/acpi/superio.asl M src/superio/ite/it8720f/acpi/superio.asl M src/superio/ite/it8721f/acpi/superio.asl M src/superio/ite/it8783ef/acpi/superio.asl M src/superio/ite/it8786e/acpi/superio.asl M src/superio/nuvoton/nct5539d/acpi/superio.asl M src/superio/nuvoton/nct6776/acpi/superio.asl M src/superio/nuvoton/npcd378/acpi/superio.asl M src/superio/smsc/sch5147/acpi/superio.asl M src/superio/winbond/w83627dhg/acpi/superio.asl M src/superio/winbond/w83627hf/acpi/superio.asl 11 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36598/6
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36598 )
Change subject: superio/*/*/acpi: Improve the readability of the IndexField ......................................................................
Patch Set 6: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36598 )
Change subject: superio/*/*/acpi: Improve the readability of the IndexField ......................................................................
superio/*/*/acpi: Improve the readability of the IndexField
Change-Id: I64fdcbcbbd54334c1c551bc1346c6000ea82c97d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36598 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/fintek/f81803a/acpi/superio.asl M src/superio/ite/it8720f/acpi/superio.asl M src/superio/ite/it8721f/acpi/superio.asl M src/superio/ite/it8783ef/acpi/superio.asl M src/superio/ite/it8786e/acpi/superio.asl M src/superio/nuvoton/nct5539d/acpi/superio.asl M src/superio/nuvoton/nct6776/acpi/superio.asl M src/superio/nuvoton/npcd378/acpi/superio.asl M src/superio/smsc/sch5147/acpi/superio.asl M src/superio/winbond/w83627dhg/acpi/superio.asl M src/superio/winbond/w83627hf/acpi/superio.asl 11 files changed, 14 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/superio/fintek/f81803a/acpi/superio.asl b/src/superio/fintek/f81803a/acpi/superio.asl index ae8e6dc..3112a4b 100644 --- a/src/superio/fintek/f81803a/acpi/superio.asl +++ b/src/superio/fintek/f81803a/acpi/superio.asl @@ -38,7 +38,7 @@ * F81803A_SHOW_UARTA If defined, UARTA will be exposed. * F81803A_SHOW_UARTB If defined, UARTB will be exposed. * F81803A_SHOW_HWMON If defined, the hardware monitor will be exposed. - * F81803A_SHOW_PME If defined, the PME/EARP/ACPI will be exposed. + * F81803A_SHOW_PME If defined, the PME/EARP/ACPI will be exposed. * * Known issue: * Do not enable UARTA and UARTB simultaneously, Linux boot will crash. @@ -66,7 +66,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8 } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x07), PNP_LOGICAL_DEVICE, 8, /* Logical device selector */ diff --git a/src/superio/ite/it8720f/acpi/superio.asl b/src/superio/ite/it8720f/acpi/superio.asl index 1e94655..1c793e2 100644 --- a/src/superio/ite/it8720f/acpi/superio.asl +++ b/src/superio/ite/it8720f/acpi/superio.asl @@ -66,7 +66,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8 } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x02), CONFIGURE_CONTROL, 8, /* Global configure control */ diff --git a/src/superio/ite/it8721f/acpi/superio.asl b/src/superio/ite/it8721f/acpi/superio.asl index c680f7e..4c54a4a 100644 --- a/src/superio/ite/it8721f/acpi/superio.asl +++ b/src/superio/ite/it8721f/acpi/superio.asl @@ -66,7 +66,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8 } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x02), CONFIGURE_CONTROL, 8, /* Global configure control */ diff --git a/src/superio/ite/it8783ef/acpi/superio.asl b/src/superio/ite/it8783ef/acpi/superio.asl index d7a320e..ed30a81 100644 --- a/src/superio/ite/it8783ef/acpi/superio.asl +++ b/src/superio/ite/it8783ef/acpi/superio.asl @@ -71,7 +71,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8 } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x02), CONFIGURE_CONTROL, 8, /* Global configure control */ diff --git a/src/superio/ite/it8786e/acpi/superio.asl b/src/superio/ite/it8786e/acpi/superio.asl index f860da6..8ea0df1 100644 --- a/src/superio/ite/it8786e/acpi/superio.asl +++ b/src/superio/ite/it8786e/acpi/superio.asl @@ -70,7 +70,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8 } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x02), CONFIGURE_CONTROL, 8, /* Global configure control */ diff --git a/src/superio/nuvoton/nct5539d/acpi/superio.asl b/src/superio/nuvoton/nct5539d/acpi/superio.asl index e259b01..ce43a77 100644 --- a/src/superio/nuvoton/nct5539d/acpi/superio.asl +++ b/src/superio/nuvoton/nct5539d/acpi/superio.asl @@ -57,7 +57,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8, } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x07), PNP_LOGICAL_DEVICE, 8, /* Logical device selector */ diff --git a/src/superio/nuvoton/nct6776/acpi/superio.asl b/src/superio/nuvoton/nct6776/acpi/superio.asl index abd5562..f6aed57 100644 --- a/src/superio/nuvoton/nct6776/acpi/superio.asl +++ b/src/superio/nuvoton/nct6776/acpi/superio.asl @@ -58,7 +58,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8, } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x07), PNP_LOGICAL_DEVICE, 8, /* Logical device selector */ diff --git a/src/superio/nuvoton/npcd378/acpi/superio.asl b/src/superio/nuvoton/npcd378/acpi/superio.asl index a4813e3..2314880 100644 --- a/src/superio/nuvoton/npcd378/acpi/superio.asl +++ b/src/superio/nuvoton/npcd378/acpi/superio.asl @@ -47,7 +47,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8, } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x07), PNP_LOGICAL_DEVICE, 8, /* Logical device selector */ diff --git a/src/superio/smsc/sch5147/acpi/superio.asl b/src/superio/smsc/sch5147/acpi/superio.asl index fb49743..6314d81 100644 --- a/src/superio/smsc/sch5147/acpi/superio.asl +++ b/src/superio/smsc/sch5147/acpi/superio.asl @@ -57,7 +57,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8 } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x07), PNP_LOGICAL_DEVICE, 8, /* Logical device selector */ diff --git a/src/superio/winbond/w83627dhg/acpi/superio.asl b/src/superio/winbond/w83627dhg/acpi/superio.asl index 301ee94..e1f2e38 100644 --- a/src/superio/winbond/w83627dhg/acpi/superio.asl +++ b/src/superio/winbond/w83627dhg/acpi/superio.asl @@ -65,7 +65,7 @@ PNP_ADDR_REG, 8, PNP_DATA_REG, 8 } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x07), PNP_LOGICAL_DEVICE, 8, /* Logical device selector */ diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl index ef4504c..87c13ac 100644 --- a/src/superio/winbond/w83627hf/acpi/superio.asl +++ b/src/superio/winbond/w83627hf/acpi/superio.asl @@ -67,10 +67,10 @@ OperationRegion (CREG, SystemIO, 0x2E, 0x02) Field (CREG, ByteAcc, NoLock, Preserve) { - ADDR, 8, - DATA, 8 + PNP_ADDR_REG, 8, + PNP_DATA_REG, 8 } - IndexField (ADDR, DATA, ByteAcc, NoLock, Preserve) + IndexField (PNP_ADDR_REG, PNP_DATA_REG, ByteAcc, NoLock, Preserve) { Offset (0x02), RST, 1, /* Soft reset */