Attention is currently required from: Felix Singer, Hung-Te Lin, Julius Werner, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79063?usp=email )
Change subject: google/*: Clean up Kconfg board selection for Google MTK boards
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/corsola/Kconfig:
https://review.coreboot.org/c/coreboot/+/79063/comment/f16551d5_86ea6fae :
PS1, Line 22: select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU
Hmm... […]
I prefer Yu-Ping's idea in the first comment.
```
config CORSOLA_HAS_MIPI_PANEL
def_bool BOARD_GOOGLE_STARYU_COMMON
config DRIVER_ANALOGIX_ANX7625
def_bool BOARD_GOOGLE_KINGLER_COMMON || BOARD_GOOGLE_CHINCHOU || ...
depends on !CORSOLA_HAS_MIPI_PANEL
config DRIVER_PARADE_PS8640
def_bool !DRIVER_ANALOGIX_ANX7625 || BOARD_GOOGLE_STEELIX
depends on !CORSOLA_HAS_MIPI_PANEL
```
Make the MIPI/DP bridge driver options mutually exclusive by driver config, but make the expectations by board config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79063?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40880e7609ba703d0053ad01da742871e54d4e7a
Gerrit-Change-Number: 79063
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 20 Nov 2023 13:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment