Attention is currently required from: Elyes Haouas, Felix Held, Jan Samek, Martin L Roth, Nico Huber.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75893?usp=email )
Change subject: doc/Makefile: Fix build dir setting
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75893/comment/6181643d_39050d38 :
PS4, Line 16: and make it writable.
I did some experimentation and it does seem to work even with `BUILDDIR = _build` instead of `BUILDD […]
Right, I mean that with "writable". Probably "configurable" is a better wording.
I would go with `?=`. https://stackoverflow.com/questions/448910/what-is-the-difference-between-th...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75893?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc44134cf1996592597252aeb9dcf7ffb3378ee3
Gerrit-Change-Number: 75893
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 16 Jun 2023 21:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment
Felix Singer (Code Review)