Attention is currently required from: Ronak Kanabar, Subrata Banik.
Appukuttan V K has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82425?usp=email )
Change subject: vc/edk2-stable202302: Add config guards to support FSP 2.4
......................................................................
Patch Set 22:
(1 comment)
File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h:
https://review.coreboot.org/c/coreboot/+/82425/comment/eb9e017d_f005bdbf?usp... :
PS12, Line 257: PLATFORM_USES_FSP2_X86_32
Added the details to this partner issue: […]
@subratabanik@google.com
I made a mistake in this patch. EnableMultiPhaseSiliconInit upd deprecated in FSP2.4 and should not be part of header file.
Removing that change from this file.
FSP2.4 build changes are addressed in this patch :https://review.coreboot.org/c/coreboot/+/82699
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82425?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idc849de73723036323f81dfd055730f6669cd52e
Gerrit-Change-Number: 82425
Gerrit-PatchSet: 22
Gerrit-Owner: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Wed, 29 May 2024 19:47:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Appukuttan V K
appukuttan.vk@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com