Wonkyu Kim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Report fixed SKU ID for TGLRVP ......................................................................
mb/intel/tglrvp: Report fixed SKU ID for TGLRVP
Report fixed SKUID(255) to support mosys
BUG=none BRANCH=none TEST=boot tigerlake rvp board and check mosys and SKUID from smbios
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I7a5beed307fd7880a6af127b2dcd06e93e50547d --- M src/mainboard/intel/tglrvp/mainboard.c 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/39269/1
diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index d74c11c..5d1a3da 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -18,6 +18,18 @@ #include <device/device.h> #include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> +#include <smbios.h> + +const char *smbios_system_sku(void) +{ + static char sku_str[7] = ""; /* sku{0..255} */ + + uint32_t sku_id = 255; + + snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id); + + return sku_str; +}
static void mainboard_init(void *chip_info) {
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Report fixed SKU ID for TGLRVP ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 25: static char sku_str[7] = ""; /* sku{0..255} */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 25: static char sku_str[7] = ""; /* sku{0..255} */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 27: uint32_t sku_id = 255; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 27: uint32_t sku_id = 255; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 29: snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 29: snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 31: return sku_str; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 31: return sku_str; please, no spaces at the start of a line
Wonkyu Kim has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Report fixed SKUID for TGLRVP ......................................................................
mb/intel/tglrvp: Report fixed SKUID for TGLRVP
Report fixed SKUID(255) to support mosys
BUG=none BRANCH=none TEST=boot tigerlake rvp board and check mosys and SKUID from smbios
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I7a5beed307fd7880a6af127b2dcd06e93e50547d --- M src/mainboard/intel/tglrvp/mainboard.c 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/39269/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39269
to look at the new patch set (#3).
Change subject: mb/intel/tglrvp: Report fixed SKU ID for TGLRVP ......................................................................
mb/intel/tglrvp: Report fixed SKU ID for TGLRVP
Report fixed SKUID(255) to support mosys
BUG=none BRANCH=none TEST=boot tigerlake rvp board and check mosys and SKUID from smbios
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I7a5beed307fd7880a6af127b2dcd06e93e50547d --- M src/mainboard/intel/tglrvp/mainboard.c 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/39269/3
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Report fixed SKU ID for TGLRVP ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 25: static char sku_str[7] = ""; /* sku{0..255} */
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 25: static char sku_str[7] = ""; /* sku{0..255} */
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 27: uint32_t sku_id = 255;
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 27: uint32_t sku_id = 255;
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 29: snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id);
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 29: snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id);
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 31: return sku_str;
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/39269/1/src/mainboard/intel/tglrvp/... PS1, Line 31: return sku_str;
please, no spaces at the start of a line
Ack
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39269
to look at the new patch set (#4).
Change subject: mb/intel/tglrvp: Report fixed SKUID for TGLRVP ......................................................................
mb/intel/tglrvp: Report fixed SKUID for TGLRVP
Report fixed SKUID(255) to support mosys
BUG=none BRANCH=none TEST=boot tigerlake rvp board and check mosys and SKUID from smbios
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I7a5beed307fd7880a6af127b2dcd06e93e50547d --- M src/mainboard/intel/tglrvp/mainboard.c 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/39269/4
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Report fixed SKUID for TGLRVP ......................................................................
Patch Set 4: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Report fixed SKUID for TGLRVP ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG@7 PS4, Line 7: mb/intel/tglrvp: Report fixed SKUID for TGLRVP Maybe:
mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG@9 PS4, Line 9: SKUID(255) SKUID (255)
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG@9 PS4, Line 9: mosys What is that?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Report fixed SKUID for TGLRVP ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG@9 PS4, Line 9: mosys
What is that?
https://chromium.googlesource.com/chromiumos/platform/mosys/
Hello Shaunak Saha, build bot (Jenkins), Rizwan Qureshi, Subrata Banik, Aamir Bohra, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39269
to look at the new patch set (#5).
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables
Report fixed SKUID(255) to support mosys.
BUG=none BRANCH=none TEST=boot tigerlake rvp board and check mosys and SKUID from smbios
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I7a5beed307fd7880a6af127b2dcd06e93e50547d --- M src/mainboard/intel/tglrvp/mainboard.c 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/39269/5
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG@7 PS4, Line 7: mb/intel/tglrvp: Report fixed SKUID for TGLRVP
Maybe: […]
Ack
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG@9 PS4, Line 9: SKUID(255)
SKUID (255)
Ack
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG@9 PS4, Line 9: mosys
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG@9 PS4, Line 9: SKUID(255)
Ack
I think Paul wanted that space after SKUID?
Hello build bot (Jenkins), Shaunak Saha, Patrick Georgi, Furquan Shaikh, Rizwan Qureshi, Subrata Banik, Nick Vaccaro, Aamir Bohra, Srinidhi N Kaushik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39269
to look at the new patch set (#6).
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables
Report fixed SKUID (255) to support mosys.
BUG=none BRANCH=none TEST=boot tigerlake rvp board and check mosys and SKUID from smbios
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I7a5beed307fd7880a6af127b2dcd06e93e50547d --- M src/mainboard/intel/tglrvp/mainboard.c 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/39269/6
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39269/4//COMMIT_MSG@9 PS4, Line 9: SKUID(255)
I think Paul wanted that space after SKUID?
Ack
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
Patch Set 6: Code-Review+1
Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
Patch Set 6: Code-Review+2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39269/6/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39269/6/src/mainboard/intel/tglrvp/... PS6, Line 23: smbios_system_sku Shouldn't this be declared __weak ?
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39269/6/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39269/6/src/mainboard/intel/tglrvp/... PS6, Line 23: smbios_system_sku
Shouldn't this be declared __weak ?
It's actual implementation which replaces week function in src/arch/x86/smbios.c. So, non week function is correct.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables
Report fixed SKUID (255) to support mosys.
BUG=none BRANCH=none TEST=boot tigerlake rvp board and check mosys and SKUID from smbios
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I7a5beed307fd7880a6af127b2dcd06e93e50547d Reviewed-on: https://review.coreboot.org/c/coreboot/+/39269 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/tglrvp/mainboard.c 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Srinidhi N Kaushik: Looks good to me, approved Wonkyu Kim: Looks good to me, but someone else must approve
diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index d74c11c..9af9d42 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -18,6 +18,16 @@ #include <device/device.h> #include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> +#include <smbios.h> + +const char *smbios_system_sku(void) +{ + static char sku_str[7] = ""; /* sku{0..255} */ + uint32_t sku_id = 255; + + snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id); + return sku_str; +}
static void mainboard_init(void *chip_info) {
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
Patch Set 7:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1176 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1175 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1174
Please note: This test is under development and might not be accurate at all!
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39269 )
Change subject: mb/intel/tglrvp: Add fixed SKUID to SMBIOS tables ......................................................................
Patch Set 7: Code-Review+2
-
9elements QA (Code Review) -
build bot (Jenkins) (Code Review)
-
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Srinidhi N Kaushik (Code Review)
-
Wonkyu Kim (Code Review)