Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41564 )
Change subject: Mushu: Enable PCIe 1d.4 to enable dgpu ......................................................................
Mushu: Enable PCIe 1d.4 to enable dgpu
BUG=b:147249494,b:147249494 BRANCH=None TEST=boot up mushu check cbmem -1 to make sure PCIe 1d.4 is enabled
Change-Id: I36404217f0ecffb0cce1105e76f507c9062df053 --- M src/mainboard/google/hatch/variants/mushu/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/41564/1
diff --git a/src/mainboard/google/hatch/variants/mushu/overridetree.cb b/src/mainboard/google/hatch/variants/mushu/overridetree.cb index 7bd1fac..1ad4777 100644 --- a/src/mainboard/google/hatch/variants/mushu/overridetree.cb +++ b/src/mainboard/google/hatch/variants/mushu/overridetree.cb @@ -183,6 +183,7 @@ device i2c 1a on end end end #I2C #4 + device pci 1d.4 on end # PCI Express port 13 device pci 1e.3 on chip drivers/spi/acpi register "name" = ""CRFP""
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41564 )
Change subject: Mushu: Enable PCIe 1d.4 to enable dgpu ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41564
to look at the new patch set (#2).
Change subject: Mushu: Enable PCIe 1d.4 to enable dgpu ......................................................................
Mushu: Enable PCIe 1d.4 to enable dgpu
BUG=b:147249494,b:147249494 BRANCH=None TEST=boot up mushu check cbmem -1 to make sure PCIe 1d.4 is enabled
Change-Id: I36404217f0ecffb0cce1105e76f507c9062df053 Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/mushu/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/41564/2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41564 )
Change subject: Mushu: Enable PCIe 1d.4 to enable dgpu ......................................................................
Mushu: Enable PCIe 1d.4 to enable dgpu
BUG=b:147249494,b:147249494 BRANCH=None TEST=boot up mushu check cbmem -1 to make sure PCIe 1d.4 is enabled
Change-Id: I36404217f0ecffb0cce1105e76f507c9062df053 Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41564 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/mushu/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/mushu/overridetree.cb b/src/mainboard/google/hatch/variants/mushu/overridetree.cb index db86d68..100f7d5 100644 --- a/src/mainboard/google/hatch/variants/mushu/overridetree.cb +++ b/src/mainboard/google/hatch/variants/mushu/overridetree.cb @@ -185,6 +185,7 @@ device i2c 1a on end end end #I2C #4 + device pci 1d.4 on end # PCI Express port 13 device pci 1e.3 on chip drivers/spi/acpi register "name" = ""CRFP""
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41564 )
Change subject: Mushu: Enable PCIe 1d.4 to enable dgpu ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4063 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4062 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4061 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4060
Please note: This test is under development and might not be accurate at all!
Shelley Chen has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/41564 )
Change subject: Mushu: Enable PCIe 1d.4 to enable dgpu ......................................................................
-
9elements QA (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Shelley Chen (Code Review)