Attention is currently required from: Bao Zheng, Martin Roth, Zheng Bao. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52657 )
Change subject: amdfwtool: Remove the misleading option characters ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS4:
the reason is that we are almost out of letters. […]
Yes, I recommend keeping generic short options such as -h, -d, and -c. -D is generic, though I think renaming it "-l" or "--list" might be more intuitive.
Overall, I think you have the right idea to make special cases use long options and avoid cluttering the short option namespace.
Patchset:
PS5: I agree that the short options don't make much sense (-O for ucode?). Thanks for cleaning this up!
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/52657/comment/32791710_2ccaa068 PS5, Line 1072: AMDFW_OPT_XHCI, In general, long options should have values beyond the ASCII character set to ensure they can't collide with short options that might be used.
More details: https://www.gnu.org/software/libc/manual/html_node/Getopt-Long-Options.html (under "Data Type: struct option")
-
David Hendricks (Code Review)