Attention is currently required from: Andrey Petrov, Arthur Heymans, Chen, Gang C, Felix Held, Julius Werner, Jérémy Compostella, Patrick Rudolph, Ronak Kanabar, Subrata Banik, Werner Zeh.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81097?usp=email )
Change subject: drivers/intel/fsp2_0: Use DECLARE_REGION for FSP-M heap
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
Hi Julius, about the usage of DECLARE_REGION, as of now I'm inclined to still keep it inside if (CONFIG(FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND)) otherwise we need to write another #if (CONFIG(FSP_SPEC_VIOLATION_XEON_SP_HEAP_WORKAROUND)) block to include the definition.
PS3:
Actually, I like that you reference the original patch but I don't think that "fixes" is appropriate […]
Sure, updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81097?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f7d7855592d99b074f7ef49c285a13f8105f089
Gerrit-Change-Number: 81097
Gerrit-PatchSet: 4
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 17 Mar 2024 11:36:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment