Attention is currently required from: Elyes Haouas, Martin L Roth, Maximilian Brune, Patrick Rudolph, Sean Rhodes.
Lean Sheng Tan has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/77882?usp=email )
Change subject: include/commonlib/sot.h: Add SOT structs
......................................................................
Patch Set 14: Code-Review+1
(3 comments)
File Documentation/drivers/cfr.md:
https://review.coreboot.org/c/coreboot/+/77882/comment/0c6825bb_b17554fb?usp... :
PS9, Line 21: The coreboot table is generated from coreboot ramstage
: code.
:
Any thoughts @gaumless@gmail. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/77882/comment/51f6ff8c_2cbd6bd0?usp... :
PS9, Line 25: tatus flags.
Any thoughts @gaumless@gmail. […]
Acknowledged
File src/commonlib/include/commonlib/cfr.h:
https://review.coreboot.org/c/coreboot/+/77882/comment/073d204b_f7a81ba8?usp... :
PS9, Line 102:
Any thoughts @gaumless@gmail. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77882?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44f006318a15556f97da286dc032c58ccb7993e4
Gerrit-Change-Number: 77882
Gerrit-PatchSet: 14
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 26 Jun 2024 13:48:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com