Change in ...coreboot[master]: superio/common/conf_mode: use pnp_write_config instead of outb calls

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31061

Change subject: superio/common/conf_mode: use pnp_write_config instead of outb calls
......................................................................

superio/common/conf_mode: use pnp_write_config instead of outb calls

Change-Id: Ibab8e798bd6bee14ef4141373e48100504d6cb46
Signed-off-by: Felix Held 
---
M src/superio/common/conf_mode.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/31061/1

diff --git a/src/superio/common/conf_mode.c b/src/superio/common/conf_mode.c
index cbe1a9e..dec630b 100644
--- a/src/superio/common/conf_mode.c
+++ b/src/superio/common/conf_mode.c
@@ -67,8 +67,7 @@

void pnp_exit_conf_mode_0202(struct device *dev)
 {
-	outb(0x02, dev->path.pnp.port);
-	outb(0x02, dev->path.pnp.port + 1);
+	pnp_write_config(dev, 0x02, (1 << 1));
 }

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31061 )

Change subject: superio/common/conf_mode: use pnp_write_config instead of outb calls
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31061 )

Change subject: superio/common/conf_mode: use pnp_write_config instead of outb calls
......................................................................

superio/common/conf_mode: use pnp_write_config instead of outb calls

Change-Id: Ibab8e798bd6bee14ef4141373e48100504d6cb46
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/31061
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
---
M src/superio/common/conf_mode.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

diff --git a/src/superio/common/conf_mode.c b/src/superio/common/conf_mode.c
index cbe1a9e..dec630b 100644
--- a/src/superio/common/conf_mode.c
+++ b/src/superio/common/conf_mode.c
@@ -67,8 +67,7 @@

void pnp_exit_conf_mode_0202(struct device *dev)
 {
-	outb(0x02, dev->path.pnp.port);
-	outb(0x02, dev->path.pnp.port + 1);
+	pnp_write_config(dev, 0x02, (1 << 1));
 }