Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Lean Sheng Tan, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55034 )
Change subject: soc/intel/elkhartlake: Update FSP-S UPD related configs part 3 ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55034/comment/2887895b_4b497e48 PS3, Line 7: soc/intel/elkhartlake: Update FSP-S UPD related configs part 3 Add least here, you can mention RP and USB in the commit message summary instead of using *part 3*.
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55034/comment/f5c4867b_37d6a32f PS3, Line 184: params->Usb2OverCurrentPin[i] = 0xff; I find the ternary operator in these cases, where the assignment of only one variable depends on the condition.
params->Usb2OverCurrentPin[i] = config->usb2_ports[i].enable ? config->usb2_ports[i].ocpin : 0xff;
https://review.coreboot.org/c/coreboot/+/55034/comment/6e939a1f_5c63f9d8 PS3, Line 226: params->PcieRpLtrMaxNoSnoopLatency[i] = 0x1003; //Max No Snoop Latency Please add a space after `//`.
Is the comment necessary? It’s already in the variable name.
https://review.coreboot.org/c/coreboot/+/55034/comment/471f2ca4_57955710 PS3, Line 227: params->PcieRpLtrMaxSnoopLatency[i] = 0x1003; //Max Snoop Latency Ditto.