Change in ...coreboot[master]: vboot_handoff: no need to set VBSD_HONOR_VIRT_DEV_SWITCH

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Joel Kitching (Code Review)

18 Mar 2019 18 Mar '19

6:53 p.m.

Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31952

Change subject: vboot_handoff: no need to set VBSD_HONOR_VIRT_DEV_SWITCH ......................................................................

vboot_handoff: no need to set VBSD_HONOR_VIRT_DEV_SWITCH

As part of chromium:942901, physical dev switch functionality is being deprecated.

This flag is no longer read after CL:1526070.

coreboot's vboot subrepository needs to be updated to include CL:1526070 before this CL can be merged.

BUG=b:124141368, b:124192753, chromium:942901 TEST=Build and deploy to eve TEST=util/lint/checkpatch.pl -g origin/master..HEAD TEST=util/abuild/abuild -B -e -y -c 50 -p none -x TEST=make clean && make test-abuild CQ-DEPEND=CL:1526070 BRANCH=none

Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Signed-off-by: Joel Kitching kitching@google.com --- M src/security/vboot/vboot_handoff.c 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31952/1

diff --git a/src/security/vboot/vboot_handoff.c b/src/security/vboot/vboot_handoff.c index 6f5b0a3..9e76073 100644 --- a/src/security/vboot/vboot_handoff.c +++ b/src/security/vboot/vboot_handoff.c @@ -79,7 +79,6 @@ vb_sd->flags |= VBSD_LF_DEV_SWITCH_ON; } /* TODO: Set these in depthcharge */ - vb_sd->flags |= VBSD_HONOR_VIRT_DEV_SWITCH; if (!CONFIG(VBOOT_PHYSICAL_REC_SWITCH)) vb_sd->flags |= VBSD_BOOT_REC_SWITCH_VIRTUAL; if (CONFIG(VBOOT_OPROM_MATTERS)) {

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Simon Glass (Code Review)

18 Mar 18 Mar

6:55 p.m.

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31952 )

Change subject: vboot_handoff: no need to set VBSD_HONOR_VIRT_DEV_SWITCH ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Gerrit-Change-Number: 31952 Gerrit-PatchSet: 1 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Comment-Date: Mon, 18 Mar 2019 09:55:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

26 Mar 26 Mar

7:07 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31952 )

Change subject: vboot_handoff: no need to set VBSD_HONOR_VIRT_DEV_SWITCH ......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/#/c/31952/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31952/5//COMMIT_MSG@7 PS5, Line 7: vboot_handoff: no need to set VBSD_HONOR_VIRT_DEV_SWITCH Please describe the change in imperative mood and not the problem.

...

Do not set VBSD_HONOR_VIRT_DEV_SWITCH

https://review.coreboot.org/#/c/31952/5//COMMIT_MSG@9 PS5, Line 9: chromium:942901 Please use the commit message hash (if committed in master) and summary or the Change-Id. Right now, going through `git log` there is no way to find this commit.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Gerrit-Change-Number: 31952 Gerrit-PatchSet: 5 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 25 Mar 2019 22:07:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Julius Werner (Code Review)

7:24 a.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31952 )

Change subject: vboot_handoff: no need to set VBSD_HONOR_VIRT_DEV_SWITCH ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/31952/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31952/5//COMMIT_MSG@9 PS5, Line 9: chromium:942901

...

Please use the commit message hash (if committed in master) and summary or the Change-Id. […]

This is not a commit, this is a Chromium bug tracker reference (to http://crbug.com/942901). You could ask Patrick to add auto-linkification to those since they're common in the CL metadata for Chromium-originated patches (e.g. see the BUG= line below).

-- To view, visit https://review.coreboot.org/c/coreboot/+/31952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Gerrit-Change-Number: 31952 Gerrit-PatchSet: 5 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 25 Mar 2019 22:24:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Joel Kitching (Code Review)

4:18 p.m.

New subject: Change in ...coreboot[master]: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH

Hello Aaron Durbin, Julius Werner, build bot (Jenkins), Simon Glass, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31952

to look at the new patch set (#7).

Change subject: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH ......................................................................

vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH

As part of chromium:942901, physical dev switch functionality is being deprecated.

This flag is no longer read after CL:1526070, and thus does not need to be set here.

coreboot's vboot subrepository needs to be updated to include CL:1526070 before this CL can be merged.

BUG=b:124141368, b:124192753, chromium:942901 TEST=Build and deploy to eve TEST=util/lint/checkpatch.pl -g origin/master..HEAD TEST=make clean && make test-abuild CQ-DEPEND=CL:1526070 BRANCH=none

Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Signed-off-by: Joel Kitching kitching@google.com --- M src/security/vboot/vboot_handoff.c 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/31952/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/31952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Gerrit-Change-Number: 31952 Gerrit-PatchSet: 7 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Joel Kitching (Code Review)

4:18 p.m.

New subject: Change in ...coreboot[master]: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31952 )

Change subject: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH ......................................................................

Patch Set 7: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/31952/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31952/5//COMMIT_MSG@7 PS5, Line 7: vboot_handoff: no need to set VBSD_HONOR_VIRT_DEV_SWITCH

...

Please describe the change in imperative mood and not the problem. […]

Done

https://review.coreboot.org/#/c/31952/5//COMMIT_MSG@9 PS5, Line 9: chromium:942901

...

This is not a commit, this is a Chromium bug tracker reference (to http://crbug.com/942901). […]

Right -- this is a Chromium bug.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Gerrit-Change-Number: 31952 Gerrit-PatchSet: 7 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 26 Mar 2019 07:18:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Julius Werner jwerner@chromium.org Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Simon Glass (Code Review)

11:56 p.m.

New subject: Change in ...coreboot[master]: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH

Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31952 )

Change subject: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH ......................................................................

Patch Set 7: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Gerrit-Change-Number: 31952 Gerrit-PatchSet: 7 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 26 Mar 2019 14:56:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

27 Mar 27 Mar

5:20 a.m.

New subject: Change in ...coreboot[master]: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31952 )

Change subject: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Gerrit-Change-Number: 31952 Gerrit-PatchSet: 7 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 26 Mar 2019 20:20:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5:19 p.m.

New subject: Change in ...coreboot[master]: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31952 )

Change subject: vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH ......................................................................

vboot_handoff: do not set VBSD_HONOR_VIRT_DEV_SWITCH

As part of chromium:942901, physical dev switch functionality is being deprecated.

This flag is no longer read after CL:1526070, and thus does not need to be set here.

coreboot's vboot subrepository needs to be updated to include CL:1526070 before this CL can be merged.

BUG=b:124141368, b:124192753, chromium:942901 TEST=Build and deploy to eve TEST=util/lint/checkpatch.pl -g origin/master..HEAD TEST=make clean && make test-abuild CQ-DEPEND=CL:1526070 BRANCH=none

Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Signed-off-by: Joel Kitching kitching@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31952 Reviewed-by: Simon Glass sjg@chromium.org Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/vboot/vboot_handoff.c 1 file changed, 0 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Simon Glass: Looks good to me, but someone else must approve Joel Kitching: Looks good to me, but someone else must approve

diff --git a/src/security/vboot/vboot_handoff.c b/src/security/vboot/vboot_handoff.c index 11831d5..1f6d4ee 100644 --- a/src/security/vboot/vboot_handoff.c +++ b/src/security/vboot/vboot_handoff.c @@ -79,7 +79,6 @@ vb_sd->flags |= VBSD_LF_DEV_SWITCH_ON; } /* TODO: Set these in depthcharge */ - vb_sd->flags |= VBSD_HONOR_VIRT_DEV_SWITCH; if (!CONFIG(VBOOT_PHYSICAL_REC_SWITCH)) vb_sd->flags |= VBSD_BOOT_REC_SWITCH_VIRTUAL; if (CONFIG(VBOOT_OPROM_MATTERS)) {

-- To view, visit https://review.coreboot.org/c/coreboot/+/31952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5849f9e0fcb8e4e6d35d542a141bf635e751af4 Gerrit-Change-Number: 31952 Gerrit-PatchSet: 8 Gerrit-Owner: Joel Kitching kitching@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Joel Kitching kitching@google.com Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Simon Glass sjg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2019

days inactive

2028

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Joel Kitching (Code Review)
Julius Werner (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Simon Glass (Code Review)