Attention is currently required from: Nico Huber, Johnny Lin, Stefan Reinauer, Paul Menzel, Rocky Phagura, Christian Walter, Angel Pons, Arthur Heymans, Kyösti Mälkki, Peter Tsung Ho Wu, Deomid "rojer" Ryabkov, Ron Minnich.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56386 )
Change subject: Add console deinit API, use in SMM handler
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56386/comment/f9878a4d_bd32cf19
PS11, Line 14: on an OCP Delta Lake server: uart8250_init disables interrupts because it
So uart8250_init() is called via console_init() in smi_handler() / smm_handler_start() (depending on […]
Patrick - just to provide some more context...when the OS takes over the console it switches to interrupt mode while coreboot uses polling mode. So when entering SMM, coreboot switches to polling mode but upon exiting SMM it needs to restore interrupts, otherwise the console will no longer work. The rule in SMM is to restore the system state otherwise the OS has no idea what happened. So this patch essentially restores console interrupts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5e51f385f83cb998c244ca1d1ffc10339d3a714
Gerrit-Change-Number: 56386
Gerrit-PatchSet: 11
Gerrit-Owner: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Peter Tsung Ho Wu
tsung@amazon.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Peter Tsung Ho Wu
tsung@amazon.com
Gerrit-Attention: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 23:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-MessageType: comment