Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44878 )
Change subject: util/spd_tools: output binaries instead of hexdumps ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44878/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44878/3//COMMIT_MSG@10 PS3, Line 10: file ending
minor nit: I'd call this `file extension`. […]
Done
https://review.coreboot.org/c/coreboot/+/44878/3/util/spd_tools/ddr4/gen_spd... File util/spd_tools/ddr4/gen_spd.go:
https://review.coreboot.org/c/coreboot/+/44878/3/util/spd_tools/ddr4/gen_spd... PS3, Line 972: bytes.Buffer
Probably not for this patch, but is there a way to tell Go this buffer is supposed to be 512 (or wha […]
Not that I know of. Buffer is variable-sized according to docs
-
Michael Niewöhner (Code Review)