Change in coreboot[master]: drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45781 )
Change subject: drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax ......................................................................
drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax
Generated 'build/dsdt.dsl' are same
Change-Id: I67fd585746df1556ceae0a3fdce595c6cf5e0f10 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/gma/acpi/common.asl 1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45781/1
diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl index 79960e1..1e7d00d 100644 --- a/src/drivers/intel/gma/acpi/common.asl +++ b/src/drivers/intel/gma/acpi/common.asl @@ -6,17 +6,17 @@
Method(BRID, 1, NotSerialized) { - Store (Match (BRIG, MEQ, Arg0, MTR, Zero, 2), Local0) - If (LEqual (Local0, Ones)) + Local0 = Match (BRIG, MEQ, Arg0, MTR, Zero, 2) + If (Local0 == Ones) { - Return (Subtract(SizeOf(BRIG), One)) + Return (SizeOf(BRIG) -1) } Return (Local0) }
Method (XBCL, 0, NotSerialized) { - Store (1, BRCT) + BRCT = 1 Return (BRIG) }
@@ -37,12 +37,12 @@ { Notify (LCD0, 0x87) } Else { - Store (BRID (XBQC ()), Local0) - If (LNotEqual (Local0, 2)) + Local0 = BRID (XBQC ()) + If (Local0 != 2) { - Decrement (Local0) + Local0-- } - XBCM (DerefOf (Index (BRIG, Local0))) + XBCM (DerefOf (BRIG [Local0])) } }
@@ -55,11 +55,11 @@ { Notify (LCD0, 0x86) } Else { - Store (BRID (XBQC ()), Local0) - If (LNotEqual (Local0, Subtract(SizeOf(BRIG), One))) + Local0 = BRID (XBQC ()) + If (Local0 != (SizeOf(BRIG) - 1)) { - Increment (Local0) + Local0++ } - XBCM (DerefOf (Index (BRIG, Local0))) + XBCM (DerefOf (BRIG [Local0])) } }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45781 )
Change subject: drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45781/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45781/1//COMMIT_MSG@9 PS1, Line 9: are same does not change.
(don't forget the final period)
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45781
to look at the new patch set (#2).
Change subject: drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax ......................................................................
drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax
Generated 'build/dsdt.dsl' does not change.
Change-Id: I67fd585746df1556ceae0a3fdce595c6cf5e0f10 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/gma/acpi/common.asl 1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45781/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45781 )
Change subject: drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45781/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45781/1//COMMIT_MSG@9 PS1, Line 9: are same
does not change. […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45781 )
Change subject: drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45781/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45781/2//COMMIT_MSG@9 PS2, Line 9: Generated 'build/dsdt.dsl' does not change. For which board? Might as well be google/zork.
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45781
to look at the new patch set (#3).
Change subject: drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax ......................................................................
drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax
Generated 'build/dsdt.dsl' for roda/rv11 does not change.
Change-Id: I67fd585746df1556ceae0a3fdce595c6cf5e0f10 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/gma/acpi/common.asl 1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/45781/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45781 )
Change subject: drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45781/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45781/2//COMMIT_MSG@9 PS2, Line 9: Generated 'build/dsdt.dsl' does not change.
For which board? Might as well be google/zork.
Done
Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45781 )
Change subject: drivers/intel/gma/acpi: Convert 'common.asl' to ASL 2.0 syntax ......................................................................
Removed Code-Review+1 by Angel Pons th3fanbus@gmail.com
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)