Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44586 )
Change subject: mb/google/dedede: Add support to override gpio config in bootblock
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44586/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44586/5//COMMIT_MSG@7
PS5, Line 7: Add support to override gpio config in bootblock
I think the latter suggestion would be a safer one since it is easy to forget that the GPIO wasn't a […]
My concern is that it's still easy to get burnt by adding a GPIO to an override table that's not in the base table. Seems like we could add a check at runtime for that situation to `gpio_configure_pads_with_override`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id66949ef4d4e9772a86089b645883a94680108ee
Gerrit-Change-Number: 44586
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Oct 2020 18:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment