Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74348 )
Change subject: ACPI: Add COMMON_ACPI_MADT_IOAPIC and CUSTOM_ACPI_MADT
......................................................................
Patch Set 4:
(1 comment)
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/74348/comment/a687e785_e0158493
PS4, Line 47:
: config ACPI_COMMON_MADT_IOAPIC
: bool
Would it make sense to describe what entries this adds?
Well it's not a visible option. How about I do a follow-up adding texts for both _LAPIC and _IOAPIC?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b77769f89cc319ad228eb37bc341e2150b8a892
Gerrit-Change-Number: 74348
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 25 Apr 2023 20:24:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment