Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43494 )
Change subject: soc/intel/common/cpu: Update COS mask calculation for nem enhanced mode
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43494/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
PS3:
First we configure the PQR_ASSOC to pick mask2 . […]
Ok, I see. Maybe I'm missing something, but does setting IA32_PQR_ASSOC when NEM mode is not enabled yet (for first setting it to 0x2) really do anything? My understanding was that the ways can't actually be protected until NEM mode is actually enabled, meaning that only the setting of 0x1 would "take effect". Could you help me understand this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54e047161853bfc70516c1d607aa479e68836d04
Gerrit-Change-Number: 43494
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 17:49:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment