Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jon Murphy, Martin Roth, Matt DeVillier, Paul Menzel, Tim Van Patten.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78231?usp=email )
Change subject: soc/amd/common/vboot: Fix PSP verstage timestamps after TSC adoption
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78231/comment/5f0e3173_79c485fd :
PS1, Line 7: Fix the PSP verstage timestamps
Maybe more specific: […]
Done
https://review.coreboot.org/c/coreboot/+/78231/comment/123842b5_da1a3079 :
PS1, Line 9: CB:74016
As git operates with hashes, I’d add that (and the summary). It’d be enough as a Fixes: tag.
Done
https://review.coreboot.org/c/coreboot/+/78231/comment/9aa78f2a_dbea6c17 :
PS1, Line 11: timestamps(in microseconds)
Please add a space before (.
Done
https://review.coreboot.org/c/coreboot/+/78231/comment/9ec07aaf_9cbf582e :
PS1, Line 13: adjust
adjusted
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78231?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e52bef22f65596152f29c511bed680427660ff5
Gerrit-Change-Number: 78231
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 06 Oct 2023 20:23:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment