Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34990 )
Change subject: mediatek/mt8183: Enable DRAM frequency 3600Mbps for EMCP DDR ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34990/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34990/2//COMMIT_MSG@9 PS2, Line 9: 3600Mbs Mbps
https://review.coreboot.org/c/coreboot/+/34990/2//COMMIT_MSG@11 PS2, Line 11: proformance performance
https://review.coreboot.org/c/coreboot/+/34990/2/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/34990/2/src/soc/mediatek/mt8183/emi... PS2, Line 23: #define LP4X_HIGH_FREQ LP4X_DDR3600 : #define LP4X_MIDDLE_FREQ LP4X_DDR3200 : #define LP4X_LOW_FREQ LP4X_DDR1600 Consider aligning these 3 lines: ``` #define LP4X_HIGH_FREQ LP4X_DDR3600 #define LP4X_MIDDLE_FREQ LP4X_DDR3200 #define LP4X_LOW_FREQ LP4X_DDR1600 ```