Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 21:
(379 comments)
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/136393e2_c9ed898a PS21, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d0cc06f4_78fe74de PS21, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0996c9ba_73524fa2 PS21, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/804b7fb2_940c9d7c PS21, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/categories.yaml:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/51c58d2d_44e2da67 PS21, Line 84: help: Adjust the amout of time before the keyboard backlight turns off when un-used 'amout' may be misspelled - perhaps 'amount'?
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e8c2b586_7676ee2f PS21, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bf8578a7_f2d488a2 PS21, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4c4b6004_707370aa PS21, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2f8f3fe6_3426b7d4 PS21, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d9f2b8bc_8c5c00ad PS21, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/99e39411_7c71993b PS21, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3b8b4ea5_b28f8cd0 PS21, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1ba056ae_8d66e4de PS21, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/026f6cfc_4f528bd3 PS21, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/83662e49_359cdb4a PS21, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e2ee4ca0_9245e488 PS21, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9f4c170c_98769cdb PS21, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/db04ebc3_48d61f5c PS21, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e3bd53b5_0cff1621 PS21, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fc1d2ba7_39746f8a PS21, Line 48: void displaySettings(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3a8fa6d6_1871d4f8 PS21, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1583a376_1b229785 PS21, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e94dda34_06b09b85 PS21, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/aecf568b_bab533ee PS21, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9451dfe2_90a018ff PS21, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/057d3f1d_f71e11aa PS21, Line 59: QString m_fileName; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b71bebc2_1646564a PS21, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f568e1c7_b7cd599d PS21, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5b0c001a_277a7888 PS21, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e0e49095_176bfc69 PS21, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/84805218_5518476d PS21, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b35819f4_1fc8853d PS21, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/aa13a0b3_16bda8d1 PS21, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bb3ef7a4_aef15f11 PS21, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/365aba8b_3ec77cd7 PS21, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7e6d3d15_7694720d PS21, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dec1a176_466d1132 PS21, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cd7af1d1_fa225323 PS21, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d168bad2_4d8cba96 PS21, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/coreboot_configurator.cpp:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6d06e20c_fa883356 PS21, Line 25: static auto s_errorWindowTitle = "Error Occured"; 'Occured' may be misspelled - perhaps 'Occurred'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a209e01b_37f2effa PS21, Line 207: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7c067e46_e6eeb1df PS21, Line 413: QMessageBox::critical(this, "Error Occured", "Can't open file to write"); 'Occured' may be misspelled - perhaps 'Occurred'?
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/41df8fb6_ee7dd8dd PS21, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f9db270e_6d3ffce3 PS21, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1243aae8_52093984 PS21, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d61a141c_c33fb6f8 PS21, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ed2f20b9_34bf6731 PS21, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d4795344_ba587da9 PS21, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a2a3957f_879ea584 PS21, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/59ffb31e_36cbae8b PS21, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/810101c1_cca685c8 PS21, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/65fa78f9_c56daba7 PS21, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e007cfd5_0a591d8b PS21, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d88df889_f434b810 PS21, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d069c7c5_dd160a03 PS21, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0b67a04e_7f1b5b23 PS21, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0172ef63_1843cb5c PS21, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f96730ed_7c38c594 PS21, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d4bcfb0f_6d3492cd PS21, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0d673a9b_1d080fc5 PS21, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e3a526da_d7069894 PS21, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/193311a6_b361cece PS21, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/02cda0d6_0afc9dff PS21, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/717281df_ded1e3fc PS21, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/430cf3e2_23fec5e9 PS21, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/75a059a6_7d8be8fc PS21, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fc27f302_7e4bb55e PS21, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/32713fa2_a37d1ca8 PS21, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e604e467_28bc84d6 PS21, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/74f0cb3a_f3b3aaa6 PS21, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/25b31789_221b47dd PS21, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/076c6628_4ea9c49b PS21, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cf35f380_68c56151 PS21, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cca48a44_a7fffea9 PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e85b6ffb_69d977bd PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/076823e1_96f6bfcb PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5b44bb1b_11d2e0eb PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0141a595_6d77209a PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9ba76e3f_2204a6cd PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7637dd42_87de68ff PS21, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f800a0e4_7596a792 PS21, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e5242bf9_5f00ad7a PS21, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0a1e2529_4ea09ec4 PS21, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f3f97395_8d08b530 PS21, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/467b8990_26653fe5 PS21, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9bcb778b_d52cfe83 PS21, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/adbfe0bd_deaf7cc6 PS21, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/112e74e3_0f07865d PS21, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e3b19fa6_89e0eeed PS21, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dcbc5785_02345fba PS21, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/43414a01_7a3494c7 PS21, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b36cae63_5382e648 PS21, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d9705c42_fab5a588 PS21, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/25e049c3_cd4b67b7 PS21, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/95dd6937_59230f52 PS21, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/340dad92_87ce3f8b PS21, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2c4176e5_04b45b11 PS21, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/729b05e3_e0b6880f PS21, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/39002fd3_06374570 PS21, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0d891957_011bbb10 PS21, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/33df3fbe_90f20bb4 PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b0aee644_094d09bf PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/19f29cf8_1ca65370 PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f0f076e9_f3ab1649 PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7fc12f77_159b5605 PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/897f19f1_9b18242c PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1ba858a4_af5099ba PS21, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a76c8104_5e8c555e PS21, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a0205db0_d5642bd2 PS21, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b3553fdb_b8a18eed PS21, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/24289812_37b7f2db PS21, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c66fb7c4_72327dce PS21, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0dc3af52_316e36a6 PS21, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a64484b5_288a3a24 PS21, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e53371e2_1808217a PS21, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ebcb44db_85bd64b4 PS21, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b500fee9_50205041 PS21, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c508306a_50df0025 PS21, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fb414401_e8a5ac51 PS21, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d01bf8ef_a95a7473 PS21, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/712ce8bb_2f923f2f PS21, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f6172c50_c57d76b6 PS21, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c2890824_f33e8bc7 PS21, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1dc98b95_d030ceaa PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8b64cbd3_9c20898f PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d073161a_3ed251eb PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/834ef842_0d8ecb82 PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e07c4708_0cee5597 PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/114ee0db_a9b486c0 PS21, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/46e362a3_5b233c41 PS21, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1580f24d_fc4a5dc3 PS21, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0bef7ac9_ccaab127 PS21, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/798698df_e5125063 PS21, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d9739cf7_85070160 PS21, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e0517574_a8a4d90c PS21, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0889a7b7_1c82ec4a PS21, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/53e89f20_9afadf60 PS21, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9136b182_ff78ac60 PS21, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fa6a5747_03d1514b PS21, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/24116db1_ed45a327 PS21, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9829aec7_390a42d3 PS21, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e0514d63_bf0861e9 PS21, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1a1a24f5_f34358cb PS21, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7cf0fb03_96977d7f PS21, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4ac1f686_1c638b03 PS21, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/17144257_e1f6b7b8 PS21, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8828d410_426d6b32 PS21, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d76e9ef2_52f44e62 PS21, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3fa3bf42_de988e57 PS21, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cbe92ddd_e7674d21 PS21, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b93de4b5_4835f0df PS21, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/80aaef7f_561c2a48 PS21, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0052229f_06080881 PS21, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bc89c8f5_ccee1ec5 PS21, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/27f55f27_d220cf8c PS21, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0db89e07_f2e981b1 PS21, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6f6c510c_4563b88c PS21, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3292c66b_63a0c912 PS21, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cd820273_3063b520 PS21, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/262d7212_7d3a85b0 PS21, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4e1f89d2_dc035c87 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e830830e_085ddfd3 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b25433d4_cc2ee6cd PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/097a2a11_d961e6e3 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/371cbdd8_663e5290 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7be34ff1_905af368 PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/86c9220b_7281983d PS21, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/320f8286_e3598242 PS21, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e2ce1e2a_f1bf6680 PS21, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/853b9b74_3e715432 PS21, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f77a61c2_e21a8892 PS21, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7c0288d5_bef7d241 PS21, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a050ede1_79d6bb7e PS21, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7f0f27c0_86f6bde9 PS21, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9841e0b4_08434cf5 PS21, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2735a0ac_8167263b PS21, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7fa31669_df4991c6 PS21, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c94116ff_a4e072fa PS21, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a9658822_c91bb71c PS21, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/83c183ff_fd1863bd PS21, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/58b51d19_170f0ad3 PS21, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e3efc6ac_5bb7d2f3 PS21, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dfdabd21_de985b97 PS21, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/548ab3a6_495447ce PS21, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/09b7ca87_578cadf2 PS21, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/98070269_175b72ec PS21, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b4479b00_55077b8b PS21, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/332202ef_bfb7495c PS21, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/771ce543_8b07e1c3 PS21, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d3538872_18343f36 PS21, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8a4f2cb2_f2173214 PS21, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d6f84f8d_a514ad2c PS21, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/08d5e258_e823a238 PS21, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1ca2575e_f3da2c49 PS21, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f1e75665_280e0f2b PS21, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4bc1819c_07302fb2 PS21, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/330f1b6a_8d8f2772 PS21, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/86e170b6_deb6871c PS21, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3263b968_2c5aad11 PS21, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/89c3be55_f13b51e6 PS21, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/203f12c7_1499739b PS21, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e0a880c8_cf9bac22 PS21, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/52bacbe1_92ed73b7 PS21, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/81896dea_c6a5838e PS21, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cade1f4d_60ff14c1 PS21, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/eba3bd49_1f7968b9 PS21, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/29619269_6e7a41c5 PS21, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/85ee9431_e430c8a4 PS21, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c5512c35_a0ea3098 PS21, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/03fa9d04_7ef1db85 PS21, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fbc33593_aa05416b PS21, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/033c82eb_b9ceaa81 PS21, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8da6c211_5b73025a PS21, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b32a2982_1ffb9e03 PS21, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c1f339f2_a0a577e5 PS21, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5e83672b_e76b7d53 PS21, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9f0bd0e5_f7d822d8 PS21, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e660ed44_b12b7d0b PS21, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4a79d531_f4664c99 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e117b6b6_94571402 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/36cfca8e_6b5c17fd PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7da44db5_4fab7aff PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/63477e5a_17c1f986 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/05892938_a05c5079 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ed3a6da1_19887de5 PS21, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ba305f38_87cb07c4 PS21, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1c7112e2_a9b633ff PS21, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/324933e8_3a5bb35d PS21, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ccad744c_62ddcb62 PS21, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8d8b0709_b1f6a155 PS21, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/315038d5_d5a0b345 PS21, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9ca76317_6a41af17 PS21, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a0d8ea0a_9a835df2 PS21, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/753f7a0d_5de0a553 PS21, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/567755ae_0ad1548a PS21, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/fba93040_002fb557 PS21, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9d1e6c15_93d322f1 PS21, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2a5911b3_4ae42e5b PS21, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ea33d454_1943b2a2 PS21, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/23c8115e_bd770726 PS21, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/67f426ce_809c86e1 PS21, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/639b9fa8_a489938c PS21, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7e5b171d_88432ddb PS21, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4d4849ae_71f4c475 PS21, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7f9cd97b_e6ab4c69 PS21, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b2235f4e_2955dcb8 PS21, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8b3083d2_bf31f453 PS21, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bc258605_e7877129 PS21, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/40adb183_a78cf00b PS21, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5fe54f15_d990c319 PS21, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/83598f87_c9f2802c PS21, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/a8446f24_420dda0d PS21, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5f5677a9_c91fba93 PS21, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b8b9a321_c976e023 PS21, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b9ac9371_48587eaf PS21, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9e927034_49eb1b61 PS21, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d8e52122_19e446a5 PS21, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3cc1ff68_c772e8b2 PS21, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b10fcb61_8fa7502c PS21, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f52cf432_4f28e351 PS21, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d2f928ab_6ca97a6e PS21, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ee66be0b_02c2801c PS21, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b67b550c_5db7d8c7 PS21, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/085f32e7_bc43b39e PS21, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/348d5eeb_9f3f62ff PS21, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f29d52fa_dec6e905 PS21, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/92238545_1527da67 PS21, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/80aa3415_c8480f7b PS21, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/775716b9_1209621a PS21, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ff6f8f00_72ba1358 PS21, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/33d89c38_eea8bc5b PS21, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/30cba2a5_4088811c PS21, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2312e857_abc1bd16 PS21, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/66662971_59152814 PS21, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/52b01ba0_1c0deb8c PS21, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/29731c76_a2c5f996 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/42a313d1_39994f53 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6ec93da6_adbbcaac PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b0cfab8d_af155391 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f76dd988_594ac9fb PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/676c406e_be1b48c8 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/643314fa_7416624c PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6767b3d7_7d02a2b8 PS21, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bcd9a6db_16e8dc77 PS21, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0faa1e6d_cd145d03 PS21, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/271f74f1_4039aeca PS21, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6ab1d21a_d26beadd PS21, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d165a596_9cb173cf PS21, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/db6f35f8_4a0ed475 PS21, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/788ff2ea_1c8e03fc PS21, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/55af6161_08bd3c3f PS21, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/013a842a_a32c5b60 PS21, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3e2b2ba2_0c82f3a9 PS21, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bfc52604_5baaedeb PS21, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c1d5a5e2_dcf55a8e PS21, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/62cbd478_a63ac1c9 PS21, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/736c507d_706d67a6 PS21, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/74d8c58b_5eb60cd8 PS21, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/68e8e9c8_12978a55 PS21, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/987bbf8b_92a842ea PS21, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1577238c_e11f16d3 PS21, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b0ff3f4e_7d79b8bc PS21, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6682d641_c9c4eb1b PS21, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4addab30_3d92df22 PS21, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/cddd9fba_4383688a PS21, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4b108329_bfcd99ac PS21, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/33858f50_b4441297 PS21, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6858e58f_65b4ed99 PS21, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1b9d5ea1_39118376 PS21, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b4595255_23d753b6 PS21, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d8f7ce9a_e5c0c3f7 PS21, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dcff8177_e658a05b PS21, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6db732c0_cffa92fa PS21, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b81595c0_fd7c30bd PS21, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e8ceb32a_96a0b79a PS21, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3106af55_49a251d7 PS21, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/447ee81c_a0d94c6b PS21, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/877b3f95_a98948fb PS21, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/44e258e6_dcd4a26d PS21, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/49bdfb97_39a43152 PS21, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bf28fc18_095cb064 PS21, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9f0ea189_9115e79c PS21, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c61b76aa_aef0017e PS21, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1509980b_5aed5c30 PS21, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b063e3d4_06f656fe PS21, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/feae0798_f3f21939 PS21, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bd359692_a1b4dbba PS21, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7ff8095c_2715a0e2 PS21, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b4ee2620_f757bdf9 PS21, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f3647009_b49ddef0 PS21, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/46afcb88_33070214 PS21, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/10cdc722_862488b4 PS21, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/962af779_6fdd50f8 PS21, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bc21abd2_ca58c826 PS21, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bbab6345_9da21d4a PS21, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8e6413f8_46ae80a1 PS21, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3b3a1788_5d7f46f8 PS21, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/505b53d8_dd8df6c3 PS21, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/6b717ed3_83c7dcd2 PS21, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/dd34c09b_c5130edf PS21, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f70dccab_250bcb0e PS21, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/5a40308c_931cb595 PS21, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2821673e_5c2328f3 PS21, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/bb34c835_886b7e09 PS21, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7c7dd40a_2371397a PS21, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/ad2e2b6e_99d1780a PS21, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/3ea6e4b6_b0df2d5a PS21, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d8efb2a3_b61067a2 PS21, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/40a345ad_c442a11c PS21, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/d7075c18_7507d12c PS21, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/10183cc1_3f21935f PS21, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2c152c11_0916bcec PS21, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/2c32232d_71113c97 PS21, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f55ac098_a0ab4baa PS21, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/323611c0_5bab376a PS21, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/aba4f8bf_dd0e10a2 PS21, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/860b5741_89b4c547 PS21, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f30b6ea3_bdfd1a34 PS21, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/f08f90bd_aefb1e55 PS21, Line 188: } please, no spaces at the start of a line
File util/coreboot-configurator/src/application/toggleswitch.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/98018e50_d9f4ee9d PS21, Line 9: /// \brief The ToggleSwitch class represents Toggle Switch widget based on QCheckBox and toggles svg with colorscheme support line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7e72bd72_48d44823 PS21, Line 12: Q_OBJECT please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/4e70308d_50449637 PS21, Line 13: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/13399076_d1471c7a PS21, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/b0d0203d_7d8718d3 PS21, Line 14: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/e17d1160_4dc8f359 PS21, Line 17: QSvgRenderer m_svgr; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/17693d46_12f289c1 PS21, Line 19: static const QByteArray s_toggleOnSvgContent; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/66d2b8cb_29787f60 PS21, Line 20: static const QByteArray s_toggleOffSvgContent; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/354ebbe9_5f1a7144 PS21, Line 22: void recolorToggleOn(const QPalette& palette); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/1de2741c_7ca73b3e PS21, Line 22: void recolorToggleOn(const QPalette& palette); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/72825157_6e5b71c3 PS21, Line 23: QByteArray m_toggleOnSvgContentColored; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/db31dd3c_bf4da7c8 PS21, Line 27: void paintEvent(QPaintEvent *event) override; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/8fb1ea94_8cca60e8 PS21, Line 27: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/c0094227_194dc5ae PS21, Line 31: bool hitButton(const QPoint &pos) const override please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/20953d3f_96f5f737 PS21, Line 31: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/91dd1c13_5addc20b PS21, Line 32: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/0717454b_60971b1f PS21, Line 33: //needs to be clickable on code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/9a7ad6cc_0695dd84 PS21, Line 34: return rect().contains(pos); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/7ccb0c23_332b0edc PS21, Line 34: return rect().contains(pos); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132347): https://review.coreboot.org/c/coreboot/+/58854/comment/59773655_472409cd PS21, Line 35: } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)