Attention is currently required from: Arthur Heymans, Robert Zieba, Raul Rangel, Nico Huber, Angel Pons, Karthik Ramasubramanian, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67931 )
Change subject: cpu/x86/smm: Add PCI BAR store functionality ......................................................................
Patch Set 11:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67931/comment/48bcf493_2f24a91a PS11, Line 7: BAR Should this be changed to resources?
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/67931/comment/81ec4df8_73436dc5 PS11, Line 175: so they : can't be tampered with. : "so SMM can tell if they've been moved"?
File src/cpu/x86/smm/pci_bar_store.c:
https://review.coreboot.org/c/coreboot/+/67931/comment/b634b357_9806ba21 PS11, Line 15: size_t num_slots, Why isn't this using SMM_PCI_BAR_STORE_NUM_SLOTS?
https://review.coreboot.org/c/coreboot/+/67931/comment/e7179ae7_7eb0c52d PS11, Line 47: SMM_PCI_BAR_STORE_NUM_BARS) do we want a warning here?
File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/c/coreboot/+/67931/comment/f67bf87b_52565bc7 PS11, Line 11: #include <types.h> Do you need to include smm.h for smm_runtime.pci_bar_store?
File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/67931/comment/d668b1c5_ee83436e PS11, Line 69: bars Can we change bars to resource or 'res' everywhere since it's no longer a BAR that's being saved?
-
Martin Roth (Code Review)