Attention is currently required from: Angel Pons.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73367 )
Change subject: memory_info: Bump to 64 DIMMs
......................................................................
Patch Set 1:
(1 comment)
File src/include/memory_info.h:
https://review.coreboot.org/c/coreboot/+/73367/comment/e28d83b4_09ed4dea
PS1, Line 11: #define DIMM_INFO_TOTAL 64
Since this is a coreboot internal structure, maybe we can simply use `DIMM_MAX` instead. […]
The code should be changed to check how many DIMMs are present and allocate the CBMEM struct dynamically. This would allow to get rid of any hardcoded maximum limit. I'll look into that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52d77c4e9bff96adba6d265a272e0e425dbdb791
Gerrit-Change-Number: 73367
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki.2011@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 04 Mar 2023 08:25:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment