Attention is currently required from: Lance Zhao, Konrad Adamczyk, Jakub Czapiga, Tim Wawrzynczak, Tim Van Patten, Karthik Ramasubramanian.
Grzegorz Bernacki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74715 )
Change subject: acpi: Add missing cbfs_unmap()
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74715/comment/f757fe56_7c281bea
PS4, Line 11:
: BUG=278264488
Google bugs should use format: `BUG=b:9999` for buganizer or `BUG=chromium:9999` for public tracker.
Done
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74715/comment/8a41546c_8acd0cef
PS4, Line 1954: cbfs_unmap(dsdt_file);
Please add a comment indicating why this is being unmapped after `slic_file`, even though the last u […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf7ba6842f42404ad8bb415f8e7fda10403cbe2e
Gerrit-Change-Number: 74715
Gerrit-PatchSet: 5
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Konrad Adamczyk
konrada@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 28 Apr 2023 09:34:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment