Change in coreboot[master]: soc/intel/*: drop UART pad configuration from common code

[Benjamin Doron (Code Review)]

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48829 )

Change subject: soc/intel/*: drop UART pad configuration from common code
......................................................................

Patch Set 6: -Code-Review

(1 comment)

https://review.coreboot.org/c/coreboot/+/48829/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48829/6//COMMIT_MSG@9 
PS6, Line 9: UART pad configuration should not be done in common code, because that
           : may cause short circuits, when the user sets a wrong UART index.
> Well each NF is "SoC functionality" but configuration of these is board's obligation. UART doesn't differ here.

I suppose?
> That is right, but it is more likely that a wrong default for a
> usually harmless Kconfig like UART_FOR_CONSOLE slips than wrong,
> explicit pad configuration. We always urge people to check pad
> configuration before they try a new port because of the short
> circuit potential. If we allow pad configuration by other means,
> we'd have to make a list of things to check... probably a growing
> one if it becomes a pattern.

That's true.

Very well. I still think that FIXED_UART_FOR_CONSOLE addresses some issues, but perhaps not all use-cases. If there have been issues here in the past as well, and this is the approach being used, then I can accept that.