[S] Change in coreboot[master]: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMS... - coreboot-gerrit

26 Apr 2023


      Attention is currently required from: Anil Kumar K, Tarun Tuli, Kapil Porwal, Sridhar Siricilla.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74763 )
Change subject: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMSTAGE
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/meteorlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/74763/comment/f15833cc_4d8805e9 
PS3, Line 131: if (!s3wake && CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE))
Can we check SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE first?
if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE) && !s3wake)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74763
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0
Gerrit-Change-Number: 74763
Gerrit-PatchSet: 3
Gerrit-Owner: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anil Kumar K anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Bora Guvendik bora.guvendik@intel.com
Gerrit-CC: Hannah Williams hannah.williams@intel.com
Gerrit-CC: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-CC: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Attention: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 22:50:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment