Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54669 )
Change subject: sb/amd/hudson: Skip setting up LPC decode for base < 0x20 ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5: Some resource log messages:x
``` Done reading resources. skipping PNP: 002e.7@f4 fixed resource, size=0! skipping PNP: 002e.7@e0 fixed resource, size=0! skipping PNP: 002e.7@e1 fixed resource, size=0! skipping PNP: 002e.108@e0 fixed resource, size=0! skipping PNP: 002e.108@e2 fixed resource, size=0! skipping PNP: 002e.108@e4 fixed resource, size=0! skipping PNP: 002e.108@f0 fixed resource, size=0! skipping PNP: 002e.108@f4 fixed resource, size=0! skipping PNP: 002e.108@f5 fixed resource, size=0! skipping PNP: 002e.108@f6 fixed resource, size=0! skipping PNP: 002e.108@f7 fixed resource, size=0! skipping PNP: 002e.209@e0 fixed resource, size=0! skipping PNP: 002e.309@e4 fixed resource, size=0! skipping PNP: 002e.309@e5 fixed resource, size=0! skipping PNP: 002e.409@f0 fixed resource, size=0! skipping PNP: 002e.a@e6 fixed resource, size=0! skipping PNP: 002e.a@e7 fixed resource, size=0! skipping PNP: 002e.b@e2 fixed resource, size=0! skipping PNP: 002e.b@e4 fixed resource, size=0! skipping PNP: 002e.f@e6 fixed resource, size=0! skipping PNP: 002e.14@e0 fixed resource, size=0! Setting resources... !! Resource didn't fit !! aligned base 1000 size 1000 limit 28f 1fff needs to be <= 28f (limit) PCI: 00:15.2 1c * [0x0 - 0xfff] io !! Resource didn't fit !! aligned base 400 size 10 limit 28f 40f needs to be <= 28f (limit) PCI: 00:11.0 20 * [0x1400 - 0x140f] io !! Resource didn't fit !! aligned base 400 size 8 limit 28f 407 needs to be <= 28f (limit) PCI: 00:11.0 10 * [0x1410 - 0x1417] io !! Resource didn't fit !! aligned base 400 size 8 limit 28f 407 needs to be <= 28f (limit) PCI: 00:11.0 18 * [0x1418 - 0x141f] io !! Resource didn't fit !! aligned base 400 size 4 limit 28f 403 needs to be <= 28f (limit) PCI: 00:11.0 14 * [0x1420 - 0x1423] io !! Resource didn't fit !! aligned base 400 size 4 limit 28f 403 needs to be <= 28f (limit) PCI: 00:11.0 1c * [0x1424 - 0x1427] io !! Resource didn't fit !! aligned base 400 size 2 limit 28f 401 needs to be <= 28f (limit) PNP: 002e.b 62 * [0x1428 - 0x1429] io node 0: mmio_basek=00200000, basek=00400000, limitk=005e0000 add_uma_resource_below_tolm: uma size 0x20000000, memory start 0x60000000 PCI: 00:00.2 44 <- [0x00f0200000 - 0x00f027ffff] size 0x00080000 gran 0x13 mem PCI: 00:01.0 10 <- [0x00e0000000 - 0x00efffffff] size 0x10000000 gran 0x1c prefmem PCI: 00:01.0 14 <- [0x0000000100 - 0x00000001ff] size 0x00000100 gran 0x08 io PCI: 00:01.0 18 <- [0x00f0280000 - 0x00f02bffff] size 0x00040000 gran 0x12 mem PCI: 00:01.1 10 <- [0x00f02c0000 - 0x00f02c3fff] size 0x00004000 gran 0x0e mem ERROR: PCI: 00:11.0 10 io size: 0x0000000008 not assigned ERROR: PCI: 00:11.0 14 io size: 0x0000000004 not assigned ERROR: PCI: 00:11.0 18 io size: 0x0000000008 not assigned ERROR: PCI: 00:11.0 1c io size: 0x0000000004 not assigned ERROR: PCI: 00:11.0 20 io size: 0x0000000010 not assigned PCI: 00:11.0 24 <- [0x00f02cc000 - 0x00f02cc7ff] size 0x00000800 gran 0x0b mem PCI: 00:12.0 10 <- [0x00f02c8000 - 0x00f02c8fff] size 0x00001000 gran 0x0c mem PCI: 00:12.2 10 <- [0x00f02cd000 - 0x00f02cd0ff] size 0x00000100 gran 0x08 mem PCI: 00:13.0 10 <- [0x00f02c9000 - 0x00f02c9fff] size 0x00001000 gran 0x0c mem PCI: 00:13.2 10 <- [0x00f02ce000 - 0x00f02ce0ff] size 0x00000100 gran 0x08 mem PCI: 00:14.2 10 <- [0x00f02c4000 - 0x00f02c7fff] size 0x00004000 gran 0x0e mem64 PNP: 002e.2 60 <- [0x00000003f8 - 0x00000003ff] size 0x00000008 gran 0x03 io PNP: 002e.2 70 <- [0x0000000004 - 0x0000000004] size 0x00000001 gran 0x00 irq PNP: 002e.5 60 <- [0x0000000060 - 0x0000000060] size 0x00000001 gran 0x00 io PNP: 002e.5 62 <- [0x0000000064 - 0x0000000064] size 0x00000001 gran 0x00 io PNP: 002e.5 70 <- [0x0000000001 - 0x0000000001] size 0x00000001 gran 0x00 irq PNP: 002e.5 72 <- [0x000000000c - 0x000000000c] size 0x00000001 gran 0x00 irq PNP: 002e.7 missing set_resources PNP: 002e.108 e0 <- [0x00000000ff - 0x00000000fe] size 0x00000000 gran 0x00 irq PNP: 002e.108 e2 <- [0x00000000ff - 0x00000000fe] size 0x00000000 gran 0x00 irq PNP: 002e.108 e4 <- [0x00000000ff - 0x00000000fe] size 0x00000000 gran 0x00 irq PNP: 002e.108 f0 <- [0x00000000ff - 0x00000000fe] size 0x00000000 gran 0x00 irq PNP: 002e.108 f4 <- [0x0000000008 - 0x0000000007] size 0x00000000 gran 0x00 irq PNP: 002e.108 f5 <- [0x00000000ff - 0x00000000fe] size 0x00000000 gran 0x00 irq PNP: 002e.108 f6 <- [0x0000000000 - 0xffffffffffffffff] size 0x00000000 gran 0x00 irq PNP: 002e.108 f7 <- [0x00000000ff - 0x00000000fe] size 0x00000000 gran 0x00 irq PNP: 002e.209 e0 <- [0x00000000ff - 0x00000000fe] size 0x00000000 gran 0x00 irq PNP: 002e.309 e4 <- [0x000000007f - 0x000000007e] size 0x00000000 gran 0x00 irq PNP: 002e.309 e5 <- [0x0000000000 - 0xffffffffffffffff] size 0x00000000 gran 0x00 irq PNP: 002e.409 f0 <- [0x00000000ff - 0x00000000fe] size 0x00000000 gran 0x00 irq PNP: 002e.509 f4 <- [0x00000000ff - 0x00000000ff] size 0x00000001 gran 0x00 irq WARNING: PNP: 002e.509 f5 irq size: 0x0000000001 not assigned in devicetree WARNING: PNP: 002e.609 f4 irq size: 0x0000000001 not assigned in devicetree WARNING: PNP: 002e.609 f5 irq size: 0x0000000001 not assigned in devicetree PNP: 002e.a e6 <- [0x000000004c - 0x000000004b] size 0x00000000 gran 0x00 irq PNP: 002e.a e7 <- [0x0000000011 - 0x0000000010] size 0x00000000 gran 0x00 irq PNP: 002e.a f2 <- [0x000000005d - 0x000000005d] size 0x00000001 gran 0x00 irq PNP: 002e.b 60 <- [0x0000000290 - 0x0000000291] size 0x00000002 gran 0x01 io PNP: 002e.b e2 <- [0x000000007f - 0x000000007e] size 0x00000000 gran 0x00 irq PNP: 002e.b e4 <- [0x00000000f1 - 0x00000000f0] size 0x00000000 gran 0x00 irq ERROR: PNP: 002e.b 62 io size: 0x0000000002 not assigned in devicetree ERROR: PNP: 002e.b 70 irq size: 0x0000000001 not assigned in devicetree WARNING: PNP: 002e.b f0 irq size: 0x0000000001 not assigned in devicetree PNP: 002e.f e6 <- [0x0000000007 - 0x0000000006] size 0x00000000 gran 0x00 irq PNP: 002e.14 e0 <- [0x0000000000 - 0xffffffffffffffff] size 0x00000000 gran 0x00 irq PCI: 00:14.4 1c <- [0x000000028f - 0x000000028e] size 0x00000000 gran 0x0c bus 01 io PCI: 00:14.4 24 <- [0x00f7ffffff - 0x00f7fffffe] size 0x00000000 gran 0x14 bus 01 prefmem PCI: 00:14.4 20 <- [0x00f7ffffff - 0x00f7fffffe] size 0x00000000 gran 0x14 bus 01 mem PCI: 00:14.5 10 <- [0x00f02ca000 - 0x00f02cafff] size 0x00001000 gran 0x0c mem PCI: 00:15.0 1c <- [0x000000028f - 0x000000028e] size 0x00000000 gran 0x0c bus 02 io PCI: 00:15.0 24 <- [0x00f7ffffff - 0x00f7fffffe] size 0x00000000 gran 0x14 bus 02 prefmem PCI: 00:15.0 20 <- [0x00f7ffffff - 0x00f7fffffe] size 0x00000000 gran 0x14 bus 02 mem PCI: 00:15.1 1c <- [0x000000028f - 0x000000028e] size 0x00000000 gran 0x0c bus 03 io PCI: 00:15.1 24 <- [0x00f7ffffff - 0x00f7fffffe] size 0x00000000 gran 0x14 bus 03 prefmem PCI: 00:15.1 20 <- [0x00f0000000 - 0x00f00fffff] size 0x00100000 gran 0x14 bus 03 mem PCI: 03:00.0 10 <- [0x00f0000000 - 0x00f0007fff] size 0x00008000 gran 0x0f mem64 PCI: 00:15.2 1c <- [0x0000000000 - 0x0000000fff] size 0x00001000 gran 0x0c bus 04 io PCI: 00:15.2 24 <- [0x00f0100000 - 0x00f01fffff] size 0x00100000 gran 0x14 bus 04 prefmem PCI: 00:15.2 20 <- [0x00f7ffffff - 0x00f7fffffe] size 0x00000000 gran 0x14 bus 04 mem PCI: 04:00.0 10 <- [0x0000000000 - 0x00000000ff] size 0x00000100 gran 0x08 io PCI: 04:00.0 18 <- [0x00f0104000 - 0x00f0104fff] size 0x00001000 gran 0x0c prefmem64 PCI: 04:00.0 20 <- [0x00f0100000 - 0x00f0103fff] size 0x00004000 gran 0x0e prefmem64 PCI: 00:16.0 10 <- [0x00f02cb000 - 0x00f02cbfff] size 0x00001000 gran 0x0c mem PCI: 00:16.2 10 <- [0x00f02cf000 - 0x00f02cf0ff] size 0x00000100 gran 0x08 mem Done setting resources. Done allocating resources. BS: BS_DEV_RESOURCES run times (exec / console): 1 / 352 ms ```
-
Paul Menzel (Code Review)