Attention is currently required from: Martin L Roth, Paul Menzel, Fred Reitberger, Rob Barnes, Karthik Ramasubramanian.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )
Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices
......................................................................
Patch Set 28:
(2 comments)
File src/soc/amd/cezanne/fch.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142947):
https://review.coreboot.org/c/coreboot/+/61259/comment/dfcad15e_27a83612
PS28, Line 162: if (dxio_clk_req == CLK_DISABLE) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-142947):
https://review.coreboot.org/c/coreboot/+/61259/comment/996b8b46_1ddfbb5b
PS28, Line 201: dxio_desc->device_number, dxio_desc->function_number, gpp_req_index, i);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77389372c60bdec572622a3b49484d4789fd4e4c
Gerrit-Change-Number: 61259
Gerrit-PatchSet: 28
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Martin L Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 02 Mar 2022 22:12:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment